Summary: | Local cover images not centered in table column in staff client search results | ||
---|---|---|---|
Product: | Koha | Reporter: | Lyle Kozloff <lyle> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | fridolin.somers, martin.renvoize, nick |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Local thumbnail displayed alongside Amazon thumbnails
Bug 19511: Local cover images not centered in table column in staff client search results Bug 19511: Local cover images not centered in table column in staff client search results Bug 19511: Local cover images not centered in table column in staff client search results |
A work around is to add the following to IntranetUserCSS: [id*="local-thumbnail"] img{ display: block; margin: auto; } Created attachment 77293 [details] [review] Bug 19511: Local cover images not centered in table column in staff client search results This patch modifies the JavaScript which embeds local cover images in staff client catalog search results. It now adds the "thumbail" class to the image, matching Amazon cover images. To test you should have one or more titles with local cover images attached. Apply the patch and clear your browser cache if necessary. Enable both the AmazonCoverImages and LocalCoverImages system preferences and perform a search which will return titles with local cover images. Confirm that local covers are styled like Amazon covers. Created attachment 77812 [details] [review] Bug 19511: Local cover images not centered in table column in staff client search results This patch modifies the JavaScript which embeds local cover images in staff client catalog search results. It now adds the "thumbail" class to the image, matching Amazon cover images. To test you should have one or more titles with local cover images attached. Apply the patch and clear your browser cache if necessary. Enable both the AmazonCoverImages and LocalCoverImages system preferences and perform a search which will return titles with local cover images. Confirm that local covers are styled like Amazon covers. Tested and confirmed local cover images are appearing quite nicely now. Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au> Created attachment 77840 [details] [review] Bug 19511: Local cover images not centered in table column in staff client search results This patch modifies the JavaScript which embeds local cover images in staff client catalog search results. It now adds the "thumbail" class to the image, matching Amazon cover images. To test you should have one or more titles with local cover images attached. Apply the patch and clear your browser cache if necessary. Enable both the AmazonCoverImages and LocalCoverImages system preferences and perform a search which will return titles with local cover images. Confirm that local covers are styled like Amazon covers. Tested and confirmed local cover images are appearing quite nicely now. Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Awesome work all! Pushed to master for 18.11 Pushed to 18.05.x for 18.05.03 Pushed to 17.11.x for 17.11.10 |
Created attachment 68369 [details] Local thumbnail displayed alongside Amazon thumbnails Local cover images are not displayed centered when compared with cover images loaded from Amazon. On Amazon loaded images the class "thumbnail" is included in the img tag, whereas in local cover images the "thumbnail" class is not present.