Summary: | Cash register report has bad erroneous results from wrong order of operations | ||
---|---|---|---|
Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
Component: | Reports | Assignee: | Nick Clemens (kidclamp) <nick> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | normal | ||
Priority: | P5 - low | CC: | fridolin.somers, jonathan.druart, m.de.rooy, marjorie.barry-vila |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 6934 | ||
Bug Blocks: | |||
Attachments: |
Bug 19551 - Fix wrong order of operations iun cash register report
Bug 19551 - Fix wrong order of operations in cash register report Bug 19551 - Fix wrong order of operations in cash register report |
Description
Nick Clemens (kidclamp)
2017-10-31 13:17:16 UTC
Created attachment 68857 [details] [review] Bug 19551 - Fix wrong order of operations iun cash register report To test: 1 - Find or create a fine for a patron 2 - Write it off 3 - Run the cash register report for current date, see your write off 4 - Run the cash register report for previous dates, still see your write off 5 - Apply patch 6 - Run cash register for current date, writee off shows (good) 7 - Run cash register report for previous dates, write off does not show (good) 8 - Sign off Created attachment 68876 [details] [review] Bug 19551 - Fix wrong order of operations in cash register report To test: 1 - Find or create a fine for a patron 2 - Write it off 3 - Home -> Reports -> Cash register 4 - Fill in current date and transaction type 'Write off' 5 - Click Submit -- see your write off 6 - Fill in previous dates and transaction type 'Write off' 7 - Click Submit -- see your write off (bad) 8 - Apply patch 9 - Rerun steps 3-7 -- write only visible for current date. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Created attachment 69371 [details] [review] Bug 19551 - Fix wrong order of operations in cash register report To test: 1 - Find or create a fine for a patron 2 - Write it off 3 - Home -> Reports -> Cash register 4 - Fill in current date and transaction type 'Write off' 5 - Click Submit -- see your write off 6 - Fill in previous dates and transaction type 'Write off' 7 - Click Submit -- see your write off (bad) 8 - Apply patch 9 - Rerun steps 3-7 -- write only visible for current date. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed to master for 18.05, thanks to everybody involved! Pushed to stable for 17.11.01, awesome work all! |