Bug 19574

Summary: Wrong itemtype can be chosen when placing holds
Product: Koha Reporter: Andreas Hedström Mace <andreas.hedstrom.mace>
Component: CirculationAssignee: Bugs List <koha-bugs>
Status: NEW --- QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: bwsdonna, gmcharlt, kyle.m.hall
Version: unspecified   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:

Description Andreas Hedström Mace 2017-11-03 09:39:36 UTC
With the syspref AllowHoldItemTypeSelection set to Allow, it is possible to add a hold for an itemtype that doesn’t actually exist at a specific branch. Say that branch A has two itemtypes: books and map, while branch B has three: books, map and audio book. It is possible to add a hold for branch A with itemtype audio book although there is no item with such an itemtype at this branch. This will cause an internal server error if you try to delete this faulty hold.

To recreate:
1) Enable AllowHoldItemTypeSelection
2) Add, or find, a bibliographic record with at least two branches and at least two items with two different itemtypes. Branch B should not have all itemtypes.
3) Add a hold for branch B, and choose an itemtype not available at this branch (there are no such items)
4) Try deleting the hold, note the internal server error.
Comment 1 Donna 2018-11-30 18:25:05 UTC
Additionally, this permits patrons to place holds on item types that are set to not allow holds, and when the item is checked it, the hold will trigger.