|
Description
Marcel de Rooy
2017-11-07 14:08:18 UTC
Created attachment 68997 [details] [review] Bug 19584: Replace label Status by Not for loan Status does not tell me that this is the Not for loan column. Trivial edit. Created attachment 69017 [details] [review] Bug 19584: Replace label Status by Not for loan Status does not tell me that this is the Not for loan column. Trivial edit. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 69018 [details] [review] Bug 19584: Check compare barcodes box when uploading barcodes This patch makes two trivial changes in the inventory interface: [1] If you have uploaded a barcode file, the compare barcodes checkbox is automatically checked. In most cases this will be the option the user wants. The compare will report missed items on the shelf. [2] If the compare barcodes checkbox is checked, the Skip items on loan- checkbox is automatically checked. This again is often desirable. If you compare, you normally are not interested in seeing items reported missing while they are checked out. Test plan: [1] Upload a barcode file on inventory. Is the compare checked? [2] Toggle compare. Does 'skip items on loan' change accordingly? Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 69739 [details] [review] Bug 19584: Check compare barcodes box when uploading barcodes This patch makes two trivial changes in the inventory interface: [1] If you have uploaded a barcode file, the compare barcodes checkbox is automatically checked. In most cases this will be the option the user wants. The compare will report missed items on the shelf. [2] If the compare barcodes checkbox is checked, the Skip items on loan- checkbox is automatically checked. This again is often desirable. If you compare, you normally are not interested in seeing items reported missing while they are checked out. Test plan: [1] Upload a barcode file on inventory. Is the compare checked? [2] Toggle compare. Does 'skip items on loan' change accordingly? Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Rebased for template footer moves Created attachment 70531 [details] [review] Bug 19584: Check compare barcodes box when uploading barcodes This patch makes two trivial changes in the inventory interface: [1] If you have uploaded a barcode file, the compare barcodes checkbox is automatically checked. In most cases this will be the option the user wants. The compare will report missed items on the shelf. [2] If the compare barcodes checkbox is checked, the Skip items on loan- checkbox is automatically checked. This again is often desirable. If you compare, you normally are not interested in seeing items reported missing while they are checked out. Test plan: [1] Upload a barcode file on inventory. Is the compare checked? [2] Toggle compare. Does 'skip items on loan' change accordingly? Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Grace Smyth <gracesmythh@gmail.com> Created attachment 71656 [details] [review] Bug 19584: Replace label Status by Not for loan Status does not tell me that this is the Not for loan column. Trivial edit. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Grace Smyth <gracesmythh@gmail.com> Created attachment 71657 [details] [review] Bug 19584: Check compare barcodes box when uploading barcodes This patch makes two trivial changes in the inventory interface: [1] If you have uploaded a barcode file, the compare barcodes checkbox is automatically checked. In most cases this will be the option the user wants. The compare will report missed items on the shelf. [2] If the compare barcodes checkbox is checked, the Skip items on loan- checkbox is automatically checked. This again is often desirable. If you compare, you normally are not interested in seeing items reported missing while they are checked out. Test plan: [1] Upload a barcode file on inventory. Is the compare checked? [2] Toggle compare. Does 'skip items on loan' change accordingly? Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Grace Smyth <gracesmythh@gmail.com> Rebased Created attachment 73255 [details] [review] Bug 19584: Replace label Status by Not for loan Status does not tell me that this is the Not for loan column. Trivial edit. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Grace Smyth <gracesmythh@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 73256 [details] [review] Bug 19584: Check compare barcodes box when uploading barcodes This patch makes two trivial changes in the inventory interface: [1] If you have uploaded a barcode file, the compare barcodes checkbox is automatically checked. In most cases this will be the option the user wants. The compare will report missed items on the shelf. [2] If the compare barcodes checkbox is checked, the Skip items on loan- checkbox is automatically checked. This again is often desirable. If you compare, you normally are not interested in seeing items reported missing while they are checked out. Test plan: [1] Upload a barcode file on inventory. Is the compare checked? [2] Toggle compare. Does 'skip items on loan' change accordingly? Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Grace Smyth <gracesmythh@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 18.05, thanks to everybody involved! |