Summary: | Internal server error if open order with deleted biblio / null biblionumber | ||
---|---|---|---|
Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
Component: | Acquisitions | Assignee: | Nick Clemens (kidclamp) <nick> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | major | ||
Priority: | P5 - low | CC: | aleisha, fridolin.somers, jonathan.druart, jschmidt, m.de.rooy, mtj |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 17631, 18256 | ||
Bug Blocks: | |||
Attachments: |
Bug 19596 - Don't try to get hold or items count for non-existent biblios
Bug 19596 - Don't try to get hold or items count for non-existent biblios Bug 19596 - Don't try to get hold or items count for non-existent biblios Bug 19596 - Don't try to get hold or items count for non-existent biblios |
Description
Nick Clemens (kidclamp)
2017-11-08 17:53:39 UTC
Created attachment 69043 [details] [review] Bug 19596 - Don't try to get hold or items count for non-existent biblios To test: 1 - Create some orders 2 - Delete the bibs (or NULL biblionumber from DB) 3 - Try to recieve some orders 4 - Internal server error 5 - Apply patch 6 - Things should work Reading the changes, there is this line 2 lines before: my $cnt_subscriptions = $biblio->subscriptions->count; I guess it will explode as well Created attachment 69047 [details] [review] Bug 19596 - Don't try to get hold or items count for non-existent biblios To test: 1 - Create some orders 2 - Delete the bibs (or NULL biblionumber from DB) 3 - Try to recieve some orders 4 - Internal server error 5 - Apply patch 6 - Things should work Current status: Needs Signoff (In reply to Jonathan Druart from comment #2) > Reading the changes, there is this line 2 lines before: > my $cnt_subscriptions = $biblio->subscriptions->count; > I guess it will explode as well Good call, I was debugging from 17.05 - the first patch without the added line will be needed there. Created attachment 69242 [details] [review] Bug 19596 - Don't try to get hold or items count for non-existent biblios Patch applies and works as expected. Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au> Created attachment 69328 [details] [review] Bug 19596 - Don't try to get hold or items count for non-existent biblios Patch applies and works as expected. Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed to master for 17.11, thanks to everybody involved! *** Bug 19293 has been marked as a duplicate of this bug. *** (In reply to Jonathan Druart from comment #7) > Pushed to master for 17.11, thanks to everybody involved! Fridolin, can we get this backported to 17.05.x please :) (In reply to Mason James from comment #9) > (In reply to Jonathan Druart from comment #7) > > Pushed to master for 17.11, thanks to everybody involved! > > Fridolin, can we get this backported to 17.05.x please :) fyi: it seems this patch can be skipped for 16.11.x (In reply to Mason James from comment #10) > (In reply to Mason James from comment #9) > > (In reply to Jonathan Druart from comment #7) > > > Pushed to master for 17.11, thanks to everybody involved! > > > > Fridolin, can we get this backported to 17.05.x please :) > > fyi: it seems this patch can be skipped for 16.11.x Thanks for pointing this. Pushed to 17.05.x for v17.05.09 |