Bug 19607

Summary: Move admin templates JavaScript to the footer: Basic parameters
Product: Koha Reporter: Owen Leonard <oleonard>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Josef Moravec <josef.moravec>
Severity: enhancement    
Priority: P5 - low CC: jonathan.druart, josef.moravec, nick, simon.pouchol, testopia
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 19560    
Bug Blocks: 17858, 19608    
Attachments: Bug 19607: Move admin templates JavaScript to the footer: Basic parameters
Bug 19607: Move admin templates JavaScript to the footer: Basic parameters
Bug 19607: Move admin templates JavaScript to the footer: Basic parameters
Bug 19607: Move admin templates JavaScript to the footer: Basic parameters

Description Owen Leonard 2017-11-10 13:19:13 UTC
In order to conform to best practices for performance staff client template javascript should be in the footer instead of the header.

This patch will do so for the "basic parameters" administration templates.
Comment 1 Owen Leonard 2017-11-10 13:26:39 UTC Comment hidden (obsolete)
Comment 2 Simon Pouchol 2017-11-10 13:36:49 UTC Comment hidden (obsolete)
Comment 3 Owen Leonard 2017-12-12 13:51:47 UTC
Created attachment 69733 [details] [review]
Bug 19607: Move admin templates JavaScript to the footer: Basic parameters

This patch modifies the staff client catalog-related administration
templates so that JavaScript is included in the footer instead of the
header.

To test, apply the patch and test the JavaScript-driven features of
each modified template: All button controls, DataTables functionality,
tabs, etc.

Signed-off-by: Simon Pouchol <simon.pouchol@biblibre.com>

Edit: Rebased on Bug 19560
Comment 4 Josef Moravec 2017-12-13 12:30:29 UTC
Created attachment 69776 [details] [review]
Bug 19607: Move admin templates JavaScript to the footer: Basic parameters

This patch modifies the staff client catalog-related administration
templates so that JavaScript is included in the footer instead of the
header.

To test, apply the patch and test the JavaScript-driven features of
each modified template: All button controls, DataTables functionality,
tabs, etc.

Signed-off-by: Simon Pouchol <simon.pouchol@biblibre.com>

Edit: Rebased on Bug 19560

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Comment 5 Jonathan Druart 2017-12-14 20:17:06 UTC
Pushed to master for 18.05, thanks to everybody involved!
Comment 6 Nick Clemens 2017-12-20 11:49:58 UTC
Awesome work all! Enhancement, not backporting for 17.11