Description
Owen Leonard
2017-11-10 14:50:26 UTC
Created attachment 69144 [details] [review] Bug 19608 - Move admin templates JavaScript to the footer: The rest This patch modifies the staff client administration templates so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of the modified templates: All button controls, DataTables functionality, tabs, etc. To test the changes to localization.tt you must have more than one translation installed. Go to admin/itemtypes.pl, edit an itemtype, and click the 'Translate into other languages' link. To test the changes to sur_modmapping.tt, go to admin/z3950servers.pl and create a new SRU server. Click the 'Modify' button next to 'SRU Search fields mapping' Created attachment 69308 [details] [review] Bug 19608 - Move admin templates JavaScript to the footer: The rest This patch modifies the staff client administration templates so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of the modified templates: All button controls, DataTables functionality, tabs, etc. To test the changes to localization.tt you must have more than one translation installed. Go to admin/itemtypes.pl, edit an itemtype, and click the 'Translate into other languages' link. To test the changes to sur_modmapping.tt, go to admin/z3950servers.pl and create a new SRU server. Click the 'Modify' button next to 'SRU Search fields mapping' Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> The item types translation popup dialog does not work for me - it opens when I click "Translate into other languages" but then I am redirected straight to localization.pl as if would click on normal link... look like going to href on that anchor is not prevented... I tried it in firefox 57 and chromium 62 Also on clone rules page the "Circulation and fines rules" menu item should be styled in bold. Sorry Created attachment 69802 [details] [review] Bug 19608 (QA follow-up) Fix redirect on localization modal This patch makes two minor corrections: 1. The item types localization modal redirect problem has been fixed by excluding the anti-clickjack code from executing in the footer. 2. The sidebar menu highlighting script has been modified to correctly handle the clone-rules page. Created attachment 70141 [details] [review] Bug 19608: Move admin templates JavaScript to the footer: The rest This patch modifies the staff client administration templates so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of the modified templates: All button controls, DataTables functionality, tabs, etc. To test the changes to localization.tt you must have more than one translation installed. Go to admin/itemtypes.pl, edit an itemtype, and click the 'Translate into other languages' link. To test the changes to sur_modmapping.tt, go to admin/z3950servers.pl and create a new SRU server. Click the 'Modify' button next to 'SRU Search fields mapping' Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 70142 [details] [review] Bug 19608: (QA follow-up) Fix redirect on localization modal This patch makes two minor corrections: 1. The item types localization modal redirect problem has been fixed by excluding the anti-clickjack code from executing in the footer. 2. The sidebar menu highlighting script has been modified to correctly handle the clone-rules page. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 70143 [details] [review] Bug 19608: (QA follow-up) Fix menu item styling for clone-rules Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Pushed to master for 18.05, thanks to everybody involved! Enhancement, skipping for 17.11.x. Awesome work everybody! Problem with sru_modmapping while replacing intranet-bottom by popup-bottom (In reply to Marcel de Rooy from comment #10) > Problem with sru_modmapping while replacing intranet-bottom by popup-bottom Will be fixed on 19436 |