|
Description
verolencinas
2017-11-13 14:51:51 UTC
Created attachment 82798 [details]
Example
Example file in MARC21 format (in spanish)
OPAC View (incomplete from example file): Contenidos: -> Universidad Nacional de Córdoba / Jorge B. Pilcher. Facultad de Derecho. -> [Estudiantes en el remate del portal del rectorado de la UNC]. -> Claustro Universidad Nacional de Córdoba / Jorge B. Pilcher. -> Interior Universidad Nacional de Córdoba / Jorge B. Pilcher. -> Salón de Grados de la Universidad / Santiago Troisi. ... Should be viewed as Contenidos: -> Postales: 1/46. Universidad Nacional de Córdoba / Jorge B. Pilcher. [1880?]. -> 2/46. Facultad de Derecho. [1905?]. -> 3/46. [Estudiantes en el remate del portal del rectorado de la UNC]. [1918]. -> 4/46. Claustro Universidad Nacional de Córdoba / Jorge B. Pilcher. [1880?]. -> 5/46. Interior Universidad Nacional de Córdoba / Jorge B. Pilcher. [1880?]. -> 6/46. Salón de Grados de la Universidad / Santiago Troisi. 1903. (In reply to verolencinas from comment #0) > The 505 field in Marc 21, Formatted Contents Note, includes subfield g > "Miscellaneous information". According to the Marc 21 format for > bibliographic data, it is used to record "volume, part, page numbering or > other extent information such as dates". If you use it in Koha, this > information isn't visible in the OPAC. Verónica, this should be dependent on ind2=0, right? What about $u? Created attachment 110027 [details] [review] Bug 19616: Add MARC21 505$g - Formatted Contents Note / Miscellaneous informatoin This adds the subfield $g to the display of the 505 field in staff and OPAC detail pages. To test: - Catalog some records using variations of 505 Examples can be found in the LOC documentation: https://www.loc.gov/marc/bibliographic/bd505.html - Verify that the display in staff and OPAC is still nice and now includes $g Created attachment 110028 [details] [review] Bug 19616: (follow-up) Reindent XSLT code used for 505 display Also adds a note at the beginning of the code block. This causes no functional change, just code clean-up. This doesn't quite work yet, behaviour of line breaks needs to be changed. Created attachment 110029 [details] [review] Bug 19616: (follow-up) Breaking items according to punctuation Previously the code assumed that $t indicates a new line in the listing. But this is not true. The standard tells us that -- or .-- will indicate a new item. "In records formulated according to AACR 2, a space-hyphen-hyphen-space ( -- ) is recorded between each item in the contents note unless a delimiter/subfield code follows in which case there is no ending space. In pre-AACR 2 records, items are separated by a period-hyphen-hyphen (.--)." The previous logic did no longer work with $g added. From the LOC examples: This would work: 505 2 0 $tBaptisms, 1816-1872 --$tChurch members, 1816-1831 --$tHistory of the Second Presbyterian Church of West Durham /$rby L. H. Fellows. 505 0 0 $tQuatrain II$g(16:35) --$tWater ways$g(1:57) --$tWaves$g(10:49). This wouldn't: 505 1 0 $gNr. 1.$tRegion Neusiedlersee --$gNr. 2.$tRegion Rosalia/Lithagebirge --$gNr. 3.$tRegion Mettelburgenland --$gNr. 4.$tRegion südliches Burgenland --$gNr. 5.$tRegion Südburgland With the patches applied, all examples should display nicely now. Created attachment 110215 [details] [review] Bug 19616: Add MARC21 505$g - Formatted Contents Note / Miscellaneous informatoin This adds the subfield $g to the display of the 505 field in staff and OPAC detail pages. To test: - Catalog some records using variations of 505 Examples can be found in the LOC documentation: https://www.loc.gov/marc/bibliographic/bd505.html - Verify that the display in staff and OPAC is still nice and now includes $g Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 110216 [details] [review] Bug 19616: (follow-up) Reindent XSLT code used for 505 display Also adds a note at the beginning of the code block. This causes no functional change, just code clean-up. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 110217 [details] [review] Bug 19616: (follow-up) Breaking items according to punctuation Previously the code assumed that $t indicates a new line in the listing. But this is not true. The standard tells us that -- or .-- will indicate a new item. "In records formulated according to AACR 2, a space-hyphen-hyphen-space ( -- ) is recorded between each item in the contents note unless a delimiter/subfield code follows in which case there is no ending space. In pre-AACR 2 records, items are separated by a period-hyphen-hyphen (.--)." The previous logic did no longer work with $g added. From the LOC examples: This would work: 505 2 0 $tBaptisms, 1816-1872 --$tChurch members, 1816-1831 --$tHistory of the Second Presbyterian Church of West Durham /$rby L. H. Fellows. 505 0 0 $tQuatrain II$g(16:35) --$tWater ways$g(1:57) --$tWaves$g(10:49). This wouldn't: 505 1 0 $gNr. 1.$tRegion Neusiedlersee --$gNr. 2.$tRegion Rosalia/Lithagebirge --$gNr. 3.$tRegion Mettelburgenland --$gNr. 4.$tRegion südliches Burgenland --$gNr. 5.$tRegion Südburgland With the patches applied, all examples should display nicely now. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Works perfectly, Signing off. Created attachment 111353 [details] [review] Bug 19616: Add MARC21 505$g - Formatted Contents Note / Miscellaneous informatoin This adds the subfield $g to the display of the 505 field in staff and OPAC detail pages. To test: - Catalog some records using variations of 505 Examples can be found in the LOC documentation: https://www.loc.gov/marc/bibliographic/bd505.html - Verify that the display in staff and OPAC is still nice and now includes $g Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 111354 [details] [review] Bug 19616: (follow-up) Reindent XSLT code used for 505 display Also adds a note at the beginning of the code block. This causes no functional change, just code clean-up. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 111355 [details] [review] Bug 19616: (follow-up) Breaking items according to punctuation Previously the code assumed that $t indicates a new line in the listing. But this is not true. The standard tells us that -- or .-- will indicate a new item. "In records formulated according to AACR 2, a space-hyphen-hyphen-space ( -- ) is recorded between each item in the contents note unless a delimiter/subfield code follows in which case there is no ending space. In pre-AACR 2 records, items are separated by a period-hyphen-hyphen (.--)." The previous logic did no longer work with $g added. From the LOC examples: This would work: 505 2 0 $tBaptisms, 1816-1872 --$tChurch members, 1816-1831 --$tHistory of the Second Presbyterian Church of West Durham /$rby L. H. Fellows. 505 0 0 $tQuatrain II$g(16:35) --$tWater ways$g(1:57) --$tWaves$g(10:49). This wouldn't: 505 1 0 $gNr. 1.$tRegion Neusiedlersee --$gNr. 2.$tRegion Rosalia/Lithagebirge --$gNr. 3.$tRegion Mettelburgenland --$gNr. 4.$tRegion südliches Burgenland --$gNr. 5.$tRegion Südburgland With the patches applied, all examples should display nicely now. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> I PQA as it does what it was requested. And I guess it doesn't hurt to make it independent on ind2. I still have my question open about $u (separate enhancement, for sure), and the incidence of ind2=0. I felt like this 'enhanced' formatting/output should be dependent on ind2, but I'm not a MARC expert and I guess if people add the subfields, they expect them to be displayed. Pushed to master for 20.11, thanks to everybody involved! enhancement will not be backported to 20.05.x |