Description
Owen Leonard
2017-11-15 14:09:54 UTC
Created attachment 69160 [details] [review] Bug 19627: Move patron clubs templates JS to the footer This patch modifies the staff client's patron clubs templates so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of each page: All button controls, DataTables functionality, tabs, etc. Created attachment 69162 [details] [review] Bug 19627: Move patron clubs templates JS to the footer This patch modifies the staff client's patron clubs templates so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of each page: All button controls, DataTables functionality, tabs, etc. Signed-off-by: Simon Pouchol <simon.pouchol@biblibre.com> There should be included tools-menu.js file to have menu item styled correctly I think. Created attachment 69608 [details] [review] Bug 19627: Follow-up: Include tools-menu.js on required templates This follow-up adds tools-menu.js to the two patron clubs templates which include the tools sidebar menu. The patch also modifies tools-menu.js so that the correct sidebar link is highlighted when editing or viewing club enrollments. To test, apply the patch and view the patron clubs main page and the patron clubs enrollments page. The sidebar menu should have the correct link highlighted in both cases. Created attachment 69630 [details] [review] [SIGNED-OFF] Bug 19627: Move patron clubs templates JS to the footer This patch modifies the staff client's patron clubs templates so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of each page: All button controls, DataTables functionality, tabs, etc. Signed-off-by: Simon Pouchol <simon.pouchol@biblibre.com> Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Created attachment 69631 [details] [review] [SIGNED-OFF] Bug 19627: Follow-up: Include tools-menu.js on required templates This follow-up adds tools-menu.js to the two patron clubs templates which include the tools sidebar menu. The patch also modifies tools-menu.js so that the correct sidebar link is highlighted when editing or viewing club enrollments. To test, apply the patch and view the patron clubs main page and the patron clubs enrollments page. The sidebar menu should have the correct link highlighted in both cases. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Created attachment 69772 [details] [review] Bug 19627: Move patron clubs templates JS to the footer This patch modifies the staff client's patron clubs templates so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of each page: All button controls, DataTables functionality, tabs, etc. Signed-off-by: Simon Pouchol <simon.pouchol@biblibre.com> Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 69773 [details] [review] Bug 19627: Follow-up: Include tools-menu.js on required templates This follow-up adds tools-menu.js to the two patron clubs templates which include the tools sidebar menu. The patch also modifies tools-menu.js so that the correct sidebar link is highlighted when editing or viewing club enrollments. To test, apply the patch and view the patron clubs main page and the patron clubs enrollments page. The sidebar menu should have the correct link highlighted in both cases. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Pushed to master for 18.05, thanks to everybody involved! Awesome work all! Enhancement, not backporting for 17.11 |