Bug 19643

Summary: Pagination buttons on staged marc management are stacking instead of inline
Product: Koha Reporter: Nick Clemens <nick>
Component: ToolsAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Marcel de Rooy <m.de.rooy>
Severity: normal    
Priority: P5 - low CC: eveal, fridolin.somers, m.de.rooy, michael, oleonard
Version: master   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 19643: Pagination buttons on staged marc management are stacking instead of inline
Bug 19643: Pagination buttons on staged marc management are stacking instead of inline
Bug 19643: Pagination buttons on staged marc management are stacking instead of inline

Description Nick Clemens 2017-11-16 17:53:10 UTC
To recreate:

1 - Stage 25+ files for import
2 - View staged marc management
3 - Note button display is incorrect
Comment 1 Michael Cabus 2017-11-16 18:01:31 UTC
This CSS can help

div.pages {
    margin: .5em 0;
    display: flex;
    flex-wrap: wrap;
}

.pages .nav {
    margin-bottom: 10px;
}
Comment 2 Owen Leonard 2017-11-16 19:27:54 UTC Comment hidden (obsolete)
Comment 3 Nick Clemens 2017-11-17 01:10:02 UTC Comment hidden (obsolete)
Comment 4 Nick Clemens 2017-11-21 20:20:42 UTC
*** Bug 19622 has been marked as a duplicate of this bug. ***
Comment 5 Marcel de Rooy 2017-11-27 13:15:25 UTC
Created attachment 69377 [details] [review]
Bug 19643: Pagination buttons on staged marc management are stacking instead of inline

This patch modifies the template for staged MARC import management to
correct a problem with the style of pagination links.

To test you must have more than 25 staged imports. Go to Tools -> Staged
MARC management. The pagination links, both at the top and the bottom,
should look correct (use multi-page SQL report results for reference).

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 6 Marcel de Rooy 2017-11-27 13:16:15 UTC
Removes the string "Page". Should not hinder translation imo.
Comment 7 Jonathan Druart 2017-12-07 12:40:14 UTC
Pushed to master for 18.05, thanks to everybody involved!
Comment 8 Ed Veal 2017-12-11 19:54:58 UTC
Thanks everyone, it will be nice to glean out the work around css. 

Ed
Comment 9 Nick Clemens 2017-12-14 12:31:50 UTC
Pushed to stable for 17.11.01, awesome work all!
Comment 10 Fridolin Somers 2017-12-20 10:55:09 UTC
Pushed to 17.05.x, will be in v17.05.07