Summary: | Move rotating collections templates JS to the footer | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Josef Moravec <josef.moravec> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | jonathan.druart, josef.moravec, nick, simon.pouchol, testopia |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 19647 | ||
Bug Blocks: | 17858 | ||
Attachments: |
Bug 19656: Move rotating collections templates JS to the footer
Bug 19656: Move rotating collections templates JS to the footer Bug 19656: Move rotating collections templates JS to the footer Bug 19656: (QA followup) Add bold style to rotating colections menu item |
Description
Owen Leonard
2017-11-20 16:34:06 UTC
Created attachment 69237 [details] [review] Bug 19656: Move rotating collections templates JS to the footer This patch modifies the staff client's rotating collections templates so that JavaScript is included in the footer instead of the header. The patch moves JavaScript from each template and the rotating collections toolbar into a single external JavaScript file. To test, apply the patch and test the JavaScript-driven features of each page: All button controls, DataTables functionality, form validation, etc. Created attachment 69505 [details] [review] Bug 19656: Move rotating collections templates JS to the footer This patch modifies the staff client's rotating collections templates so that JavaScript is included in the footer instead of the header. The patch moves JavaScript from each template and the rotating collections toolbar into a single external JavaScript file. To test, apply the patch and test the JavaScript-driven features of each page: All button controls, DataTables functionality, form validation, etc. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Created attachment 69563 [details] [review] Bug 19656: Move rotating collections templates JS to the footer This patch modifies the staff client's rotating collections templates so that JavaScript is included in the footer instead of the header. The patch moves JavaScript from each template and the rotating collections toolbar into a single external JavaScript file. To test, apply the patch and test the JavaScript-driven features of each page: All button controls, DataTables functionality, form validation, etc. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 69564 [details] [review] Bug 19656: (QA followup) Add bold style to rotating colections menu item Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Nice work! Pushed to master for 18.05, thanks to everybody involved! Awesome work all! Skipping for 17.11, enhancement |