| Summary: | Move JS to the footer: Suggestions and tags | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Josef Moravec <josef.moravec> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | claire_gravely, jonathan.druart, josef.moravec, nick, simon.pouchol, testopia |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 17858 | ||
| Attachments: |
Bug 19659: Move JS to the footer: Suggestions and tags
Bug 19659: Move JS to the footer: Suggestions and tags Bug 19659: Move JS to the footer: Suggestions and tags Bug 19659: Move JS to the footer: Suggestions and tags |
||
|
Description
Owen Leonard
2017-11-20 18:04:20 UTC
Created attachment 69240 [details] [review] Bug 19659: Move JS to the footer: Suggestions and tags This patch modifies the staff client's suggestions and tags templates so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of suggestions and tags pages: All button controls, DataTables functionality, form validation, etc. Getting JS ReferenceError: $ is not defined suggestion.pl:554:5 Created attachment 69276 [details] [review] Bug 19659: Move JS to the footer: Suggestions and tags This patch modifies the staff client's suggestions and tags templates so that JavaScript is included in the footer instead of the header. This patch adds a new JS file, acquisitions-menu.js, which will be added to each template which has the Acquisitions sidebar menu (in this case, suggestions). Highlighting of the current page in the sidebar menu will be broken for pages which have not been modified to use this file. To test, apply the patch and test the JavaScript-driven features of suggestions and tags pages: All button controls, DataTables functionality, form validation, etc. Created attachment 69285 [details] [review] Bug 19659: Move JS to the footer: Suggestions and tags This patch modifies the staff client's suggestions and tags templates so that JavaScript is included in the footer instead of the header. This patch adds a new JS file, acquisitions-menu.js, which will be added to each template which has the Acquisitions sidebar menu (in this case, suggestions). Highlighting of the current page in the sidebar menu will be broken for pages which have not been modified to use this file. To test, apply the patch and test the JavaScript-driven features of suggestions and tags pages: All button controls, DataTables functionality, form validation, etc. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Created attachment 69597 [details] [review] Bug 19659: Move JS to the footer: Suggestions and tags This patch modifies the staff client's suggestions and tags templates so that JavaScript is included in the footer instead of the header. This patch adds a new JS file, acquisitions-menu.js, which will be added to each template which has the Acquisitions sidebar menu (in this case, suggestions). Highlighting of the current page in the sidebar menu will be broken for pages which have not been modified to use this file. To test, apply the patch and test the JavaScript-driven features of suggestions and tags pages: All button controls, DataTables functionality, form validation, etc. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Pushed to master for 18.05, thanks to everybody involved! Awesome work all! Skipping for 17.11, enhancement |