Summary: | Move JS to the footer: Reports | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Josef Moravec <josef.moravec> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | jonathan.druart, josef.moravec, nick, simon.pouchol, testopia |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Medium patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 17858, 34533 | ||
Attachments: |
Bug 19663: Move JS to the footer: Reports
Bug 19663: Move JS to the footer: Reports Bug 19663: Move JS to the footer: Reports Bug 19663: Move JS to the footer: Reports |
Description
Owen Leonard
2017-11-21 13:20:49 UTC
Created attachment 69249 [details] [review] Bug 19663: Move JS to the footer: Reports This patch modifies the staff client's reports templates so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of reports pages: All button controls, DataTables functionality, form validation, etc. Created attachment 69264 [details] [review] Bug 19663: Move JS to the footer: Reports This patch modifies the staff client's reports templates so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of reports pages: All button controls, DataTables functionality, form validation, etc. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Owen, just a small thing: the function Dopop in cat_issues_top.tt template should be probably removed, it is not used if I am reading it right. Otherwise looks good! Created attachment 69603 [details] [review] Bug 19663: Move JS to the footer: Reports This patch modifies the staff client's reports templates so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of reports pages: All button controls, DataTables functionality, form validation, etc. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Fix for QA: Remove unused Dopop function. Created attachment 69771 [details] [review] Bug 19663: Move JS to the footer: Reports This patch modifies the staff client's reports templates so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of reports pages: All button controls, DataTables functionality, form validation, etc. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Fix for QA: Remove unused Dopop function. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Pushed to master for 18.05, thanks to everybody involved! Awesome work all! Enhancement, not backporting for 17.11 |