|
Description
Nick Clemens (kidclamp)
2017-11-21 14:01:18 UTC
Created attachment 69247 [details] [review] Bug 19671: Map itemtypes to hash for correct display in issues_stats.pl To test: 1 - Run the circulation wizard with itemtypes as columns, shelving locations as rows - display on screen 2 - Note all itemtype values are blank 3 - Switch rows/columns - same issue 4 - Apply patch 5 - Re-run reports 6 - Itemtypes should diplsay correctly Hullo, I find that my itemtypes drop down list just shows blanks instead of the item types with patch applied. When I run the report I get a column for Books in the results but then a Blank column next to it. I was going to submit the same patch, I am going to sign it off No it's wrong, the form now contains an empty dropdown list. Created attachment 69951 [details] [review] Bug 19671: Map itemtypes to hash for correct display in issues_stats.pl To test: 1 - Run the circulation wizard with itemtypes as columns, shelving locations as rows - display on screen 2 - Note all itemtype values are blank 3 - Switch rows/columns - same issue 4 - Apply patch 5 - Re-run reports 6 - Itemtypes should display correctly I have applied the patch (on Koha 17.05) and can confirm that item types are now displayed correctly in the report. Created attachment 71433 [details] [review] Bug 19671: Map itemtypes to hash for correct display in issues_stats.pl To test: 1 - Run the circulation wizard with itemtypes as columns, shelving locations as rows - display on screen 2 - Note all itemtype values are blank 3 - Switch rows/columns - same issue 4 - Apply patch 5 - Re-run reports 6 - Itemtypes should display correctly Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Created attachment 71535 [details] [review] Bug 19671: Map itemtypes to hash for correct display in issues_stats.pl To test: 1 - Run the circulation wizard with itemtypes as columns, shelving locations as rows - display on screen 2 - Note all itemtype values are blank 3 - Switch rows/columns - same issue 4 - Apply patch 5 - Re-run reports 6 - Itemtypes should display correctly Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 18.05, thanks to everybody involved! Awesome work all! Pushed to stable for 17.11.03 Pushed to 17.05.x for v17.05.12 |