Bug 19674

Summary: Broken indicators of changed fields in manage staged MARC records template
Product: Koha Reporter: Owen Leonard <oleonard>
Component: ToolsAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Marcel de Rooy <m.de.rooy>
Severity: minor    
Priority: P5 - low CC: fridolin.somers, jonathan.druart, m.de.rooy, nick
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 16538    
Bug Blocks:    
Attachments: Bug 19674: Broken indicators of changed fields in manage staged MARC records template
Bug 19674: Broken indicators of changed fields in manage staged MARC records template
Bug 19674: Broken indicators of changed fields in manage staged MARC records template

Description Owen Leonard 2017-11-21 16:15:38 UTC
May patch for Bug 16538 removed some CSS which should have stayed. Without it, the manage staged MARC records page always says that all matching options have been modified.
Comment 1 Owen Leonard 2017-11-21 16:21:13 UTC Comment hidden (obsolete)
Comment 2 Claire Gravely 2017-11-22 08:52:40 UTC
Created attachment 69269 [details] [review]
Bug 19674: Broken indicators of changed fields in manage staged MARC records template

This patch returns some CSS to the manage staged MARC records template
which was incorrectly removed by Gug 16538.

To test, apply the patch and go to Tools -> Staged MARC management.
Choose a staged MARC file.

Changing any of the <select> fields in the first section should cause a
label to appear showing that the selection has changed, along with a
link to reset the option to its original state. Clicking 'Reset' should
make the label and the link disappear.

Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>
Comment 3 Marcel de Rooy 2017-11-27 13:20:59 UTC
Created attachment 69378 [details] [review]
Bug 19674: Broken indicators of changed fields in manage staged MARC records template

This patch returns some CSS to the manage staged MARC records template
which was incorrectly removed by Gug 16538.

To test, apply the patch and go to Tools -> Staged MARC management.
Choose a staged MARC file.

Changing any of the <select> fields in the first section should cause a
label to appear showing that the selection has changed, along with a
link to reset the option to its original state. Clicking 'Reset' should
make the label and the link disappear.

Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Jonathan Druart 2017-12-07 14:25:17 UTC
Pushed to master for 18.05, thanks to everybody involved!
Comment 5 Nick Clemens 2017-12-14 12:36:14 UTC
Pushed to stable for 17.11.01, awesome work all!
Comment 6 Fridolin Somers 2017-12-21 08:12:13 UTC
Pushed to 17.05.x, will be in v17.05.07