Summary: | label-item-search.pl result count formatting error when there is only one page | ||
---|---|---|---|
Product: | Koha | Reporter: | David Bourgault <david.bourgault> |
Component: | Label/patron card printing | Assignee: | David Bourgault <david.bourgault> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | fridolin.somers, m.de.rooy, nick, philippe.blouin |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 19681 - Correct result count formatting
Bug 19681 - Correct result count formatting Bug 19681 - Correct result count formatting Bug 19681: Correct result count formatting |
Description
David Bourgault
2017-11-22 18:55:34 UTC
Created attachment 69289 [details] [review] Bug 19681 - Correct result count formatting This simply passes the missing information to the template. Test plan: 0) Apply patch 1) Go to Tools > Label creator > New > Label batch 2) Press 'Add items' 3) Do a search that will return few items 4) The result count will read "Results 1 through X of X" Created attachment 69293 [details] [review] Bug 19681 - Correct result count formatting This simply passes the missing information to the template. Test plan: 0) Apply patch 1) Go to Tools > Label creator > New > Label batch 2) Press 'Add items' 3) Do a search that will return few items 4) The result count will read "Results 1 through X of X" Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 69294 [details] [review] Bug 19681 - Correct result count formatting Small correction, previous patch accidentally changed the file mode to 644. -- This simply passes the missing information to the template. Test plan: 0) Apply patch 1) Go to Tools > Label creator > New > Label batch 2) Press 'Add items' 3) Do a search that will return few items 4) The result count will read "Results 1 through X of X" Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 69333 [details] [review] Bug 19681: Correct result count formatting This simply passes the missing information to the template. Test plan: 0) Apply patch 1) Go to Tools > Label creator > New > Label batch 2) Press 'Add items' 3) Do a search that will return few items 4) The result count will read "Results 1 through X of X" Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed to master for 18.05, thanks to everybody involved! Pushed to stable for 17.11.01, awesome work all! Pushed to 17.05.x, will be in v17.05.07 |