| Summary: | Edited shipping cost in invoice doesn't save | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
| Component: | Acquisitions | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Kyle M Hall (khall) <kyle> |
| Severity: | major | ||
| Priority: | P5 - low | CC: | fridolin.somers, jonathan.druart, jzairo, kyle, nick |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 19694: Force scalar context for output_pref called with billingdate
Bug 19694: Force scalar context for output_pref called with billingdate Bug 19694: Force scalar context for output_pref called with billingdate |
||
|
Description
Katrin Fischer
2017-11-27 11:33:49 UTC
Created attachment 69922 [details] [review] Bug 19694: Force scalar context for output_pref called with billingdate If no string is passed to output_pref, it needs to be called in scalar context (to avoid a shift in the hash elements). Here we have billingdate that is not defined yet (NULL) Test plan: - Search for an existing invoice - Show details - Changing shipping cost - Save - Verify the new amount is shown And it has the side-effect to set billingdate to 0000-00-00 The logs displayed: Odd number of elements in hash assignment at /home/vagrant/kohaclone/C4/Acquisition.pm line 2773. Created attachment 69962 [details] [review] Bug 19694: Force scalar context for output_pref called with billingdate If no string is passed to output_pref, it needs to be called in scalar context (to avoid a shift in the hash elements). Here we have billingdate that is not defined yet (NULL) Test plan: - Search for an existing invoice - Show details - Changing shipping cost - Save - Verify the new amount is shown Signed-off-by: Jon Knight <J.P.Knight@lboro.ac.uk> Created attachment 70001 [details] [review] Bug 19694: Force scalar context for output_pref called with billingdate If no string is passed to output_pref, it needs to be called in scalar context (to avoid a shift in the hash elements). Here we have billingdate that is not defined yet (NULL) Test plan: - Search for an existing invoice - Show details - Changing shipping cost - Save - Verify the new amount is shown Signed-off-by: Jon Knight <J.P.Knight@lboro.ac.uk> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Pushed to master for 18.05, thanks to everybody involved! *** Bug 18793 has been marked as a duplicate of this bug. *** Awesome work all! Pushed to stable for 17.11.02 Pushed to 17.05.x for v17.05.08 |