Bug 19695

Summary: Uncertain prices should not use find in list context
Product: Koha Reporter: Stefan Berndtsson <stefan.berndtsson>
Component: AcquisitionsAssignee: Stefan Berndtsson <stefan.berndtsson>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: critical    
Priority: P5 - low CC: fridolin.somers, jonathan.druart+koha
Version: master   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 15685, 18539    
Bug Blocks:    
Attachments: Fix another instance of ->find in list context.
Bug 19695: Fix another instance of ->find in list context (uncertainprice.pl)

Description Stefan Berndtsson 2017-11-27 11:41:12 UTC
When clicking on Uncertain prices button from a basket, the log fails with the following message:
Cannot use "->find" in list context at <path>/acqui/uncertainprice.pl line 76.

Similar to Bug 18179.
Comment 1 Stefan Berndtsson 2017-11-27 11:41:44 UTC
Created attachment 69369 [details] [review]
Fix another instance of ->find in list context.
Comment 2 Jonathan Druart 2017-11-27 17:23:42 UTC
Created attachment 69396 [details] [review]
Bug 19695: Fix another instance of ->find in list context (uncertainprice.pl)

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 3 Jonathan Druart 2017-11-27 17:24:36 UTC
Trivial, skipping QA.
Comment 4 Jonathan Druart 2017-11-27 17:26:25 UTC
Patch pushed to master for 17.11, thanks Stefan!
Comment 5 Fridolin Somers 2017-12-11 08:11:27 UTC
Depends on Bug 15685 which adds this line.
Comment 6 Fridolin Somers 2017-12-11 08:12:02 UTC
Bug 15685 not in 17.05.x