Bug 19698

Summary: "Add message" for patron don't use OPAC description if message type is OPAC
Product: Koha Reporter: Sophie MEYNIEUX <sophie.meynieux>
Component: PatronsAssignee: Bugs List <koha-bugs>
Status: CLOSED INVALID QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: gmcharlt, jonathan.druart, kyle
Version: Main   
Hardware: All   
OS: All   
GIT URL: Initiative type: ---
Sponsorship status: --- Comma delimited list of Sponsors:
Crowdfunding goal: 0 Crowdfunding committed: 0
Crowdfunding contact: Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Description Sophie MEYNIEUX 2017-11-27 14:03:12 UTC
If you want to add a message to a patron, you can choose OPAC or intranet message type.
Predefined messages are defined in BOR_NOTES authorised value. 
But OPAC description is never used even if message type is OPAC
Comment 1 Jonathan Druart 2017-12-20 23:58:55 UTC
Hi Sophie,

The "type" of the message can be either "L" or "B" (Librarian/staff and Borrower/opac, I guess).
If you use "intranet", the message will be displayed on the patron's page, staff-side.
If you pick "opac", it will be displayed on the patron's pages (opac-user and sco).

Does it make sense?

Marking as invalid, please reopen if I misunderstood.
Comment 2 Sophie MEYNIEUX 2018-01-03 11:23:34 UTC
Yes they are displayed in the right place but not with the right description
Comment 3 Katrin Fischer 2018-01-03 16:21:20 UTC
Hi Sophie,

I think the authorised_value is used in an untypical way here (like MAN_INV or INVENTORY). It allows you to store a text snippet or template for a text that then can be changed and edited before saving the message. When the message is pulled for display, it will pull the stored text from the database, the authorised_value code is not stored.
Because of this the current behaviour makes sense to me - the OPAC value has no meaning here.

I think if we wanted it to pull different template texts depending on if you selected staff or OPAC we'd need to use Ajax similar to what we do for statistic values depending on fund selection on the acquisition order page. It might also cause problems if the text will be overwritten after you already edited it.