Summary: | Basket not displaying correctly on home page | ||
---|---|---|---|
Product: | Koha | Reporter: | David Bourgault <david.bourgault> |
Component: | OPAC | Assignee: | David Bourgault <david.bourgault> |
Status: | CLOSED FIXED | QA Contact: | Josef Moravec <josef.moravec> |
Severity: | minor | ||
Priority: | P5 - low | CC: | fridolin.somers, josef.moravec, nick, philippe.blouin |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 19702 - Correct cookie path in Basket.js
Bug 19702 - Correct cookie path in Basket.js Bug 19702: Correct cookie path in Basket.js |
Description
David Bourgault
2017-11-27 21:04:27 UTC
Created attachment 69402 [details] [review] Bug 19702 - Correct cookie path in Basket.js This corrects the cookie path in bootstrap/js/basket.js. It used to take the default value (current page path), but will now be "/" Test plan: 0) Visit the OPAC, add a book to your basket 1) Navigate to the OPAC's homepage (www.domain.com, without the /cgi-bin/koha) -> The basket will display as empty 2) Apply patch 3) Clear your cookies and your cache 4) Redo step 1) -> Basket will display correctly Created attachment 69407 [details] [review] Bug 19702 - Correct cookie path in Basket.js Patch applies without issue and functions as descibed. Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au> Created attachment 70083 [details] [review] Bug 19702: Correct cookie path in Basket.js This corrects the cookie path in bootstrap/js/basket.js. It used to take the default value (current page path), but will now be "/" Test plan: 0) Visit the OPAC, add a book to your basket 1) Navigate to the OPAC's homepage (www.domain.com, without the /cgi-bin/koha) -> The basket will display as empty 2) Apply patch 3) Clear your cookies and your cache 4) Redo step 1) -> Basket will display correctly Patch applies without issue and functions as descibed. Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Pushed to master for 18.05, thanks to everybody involved! Awesome work all, pushed to stable for 17.11.02 Pushed to 17.05.x for v17.05.08 |