Bug 19714

Summary:	2 occurrences of memberofinstitution have not been removed
Product:	Koha	Reporter:	Jonathan Druart <jonathan.druart>
Component:	Architecture, internals, and plumbing	Assignee:	Jessica <jessicafreeman>
Status:	CLOSED FIXED	QA Contact:	Josef Moravec <josef.moravec>
Severity:	trivial
Priority:	P5 - low	CC:	jessicafreeman, josef.moravec
Version:	unspecified	Keywords:	Academy
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	Trivial patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:
Circulation function:
Bug Depends on:	11751
Bug Blocks:
Attachments:	Bug: 19714 - Removing 2 occurrences of memberofinstitution To Test: 1/grep for memberofinstitution 2/Notice it occurs in C4/UsageStats.pm and t/db_dependent/UsageStats.t 3/grep again, notice they have been removed Bug: 19714 - Removing 2 occurrences of memberofinstitution Bug: 19714 - Removing 2 occurrences of memberofinstitution Bug: 19714 - Removing 2 occurrences of memberofinstitution

Description Jonathan Druart 2017-11-29 14:12:48 UTC

C4/UsageStats.pm:        memberofinstitution
t/db_dependent/UsageStats.t:        memberofinstitution

Comment 1 Jessica 2017-12-18 22:45:45 UTC

Created attachment 69868 [details] [review]
Bug: 19714 - Removing 2 occurrences of memberofinstitution To Test: 1/grep for memberofinstitution 2/Notice it occurs in C4/UsageStats.pm and t/db_dependent/UsageStats.t 3/grep again, notice they have been removed

Comment 2 Jessica 2017-12-18 22:47:17 UTC

Created attachment 69869 [details] [review]
Bug: 19714 - Removing 2 occurrences of memberofinstitution

To Test:
1/grep for memberofinstitution
2/Notice it occurs in C4/UsageStats.pm and t/db_dependent/UsageStats.t
3/grep again, notice they have been removed

Comment 3 Katrin Fischer 2017-12-19 07:08:28 UTC

Created attachment 69894 [details] [review]
Bug: 19714 - Removing 2 occurrences of memberofinstitution

To Test:
1/grep for memberofinstitution
2/Notice it occurs in C4/UsageStats.pm and t/db_dependent/UsageStats.t
3/grep again, notice they have been removed

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Comment 4 Katrin Fischer 2017-12-19 07:08:47 UTC

Thank you, Jessica!

Comment 5 Josef Moravec 2017-12-19 09:29:22 UTC

Created attachment 69897 [details] [review]
Bug: 19714 - Removing 2 occurrences of memberofinstitution

To Test:
1/grep for memberofinstitution
2/Notice it occurs in C4/UsageStats.pm and t/db_dependent/UsageStats.t
3/grep again, notice they have been removed

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Comment 6 Jonathan Druart 2017-12-19 14:17:28 UTC

Patch pushed to master for 18.05.

Thanks Jessica and congrats for your first patch in!