Summary: | Overdues without a fine rule add warnings to log | ||
---|---|---|---|
Product: | Koha | Reporter: | Kyle M Hall (khall) <kyle> |
Component: | Fines and fees | Assignee: | Kyle M Hall (khall) <kyle> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | jonathan.druart, nick |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 19750 - Overdues without a fine rule add warnings to log
Bug 19750 - Overdues without a fine rule add warnings to log Bug 19750 - Overdues without a fine rule add warnings to log |
Description
Kyle M Hall (khall)
2017-12-05 15:23:21 UTC
Created attachment 69509 [details] [review] Bug 19750 - Overdues without a fine rule add warnings to log When running fines.pl, any overdue items that have no corresponding circulation rule will generate the following warning: Use of uninitialized value $amount in numeric gt (>) at /usr/share/koha/bin/cronjobs/fines.pl line 133. Test Plan: 1) Create a single circ rule 2) Backdate a checkout so it is overdue 3) Delete the circ rule 4) Run fines.pl, note the warning 5) Apply this patch 6) Run fines.pl, note the warning is gone Created attachment 71101 [details] [review] Bug 19750 - Overdues without a fine rule add warnings to log Followed test plan and works as expected. Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au> Created attachment 71110 [details] [review] Bug 19750 - Overdues without a fine rule add warnings to log Followed test plan and works as expected. Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Dilan, please do not remove the original commit message when signing off. Pushed to master for 18.05, thanks to everybody involved! Awesome work all, pushed to stable for 17.11.03 |