Bug 19751

Summary: Holds awaiting pickup report should not be fixed-width
Product: Koha Reporter: Owen Leonard <oleonard>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Josef Moravec <josef.moravec>
Severity: enhancement    
Priority: P5 - low CC: ByWaterSandboxes, fridolin.somers, josef.moravec, nick
Version: Main   
Hardware: All   
OS: All   
URL: /cgi-bin/koha/circ/waitingreserves.pl
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 19751: Holds awaiting pickup report should not be fixed-width
Bug 19751: Holds awaiting pickup report should not be fixed-width
Bug 19751: Holds awaiting pickup report should not be fixed-width

Description Owen Leonard 2017-12-05 15:26:28 UTC
The holds awaiting pickup report should not be fixed-width. The table can be very wide, especially with the width of "Cancel and return to..." buttons with long branch names.
Comment 1 Owen Leonard 2017-12-05 15:31:57 UTC Comment hidden (obsolete)
Comment 2 ByWaterSandboxes 2017-12-05 15:52:13 UTC
Patch tested with a sandbox, by George Williams <george@nekls.org>
Comment 3 ByWaterSandboxes 2017-12-05 15:52:27 UTC Comment hidden (obsolete)
Comment 4 Josef Moravec 2017-12-07 09:33:54 UTC
Created attachment 69600 [details] [review]
Bug 19751: Holds awaiting pickup report should not be fixed-width

This patch changes the grid used for the holds awaiting pickup report so
that the results are full page and fluid instead of fixed-width.

To test, apply this patch and the patch for Bug 19700 if necessary.

View the holds awaiting pickup report. The report should fluidly fill
the page width.

Test with the CircSidebar system preference enabled and disabled.

Signed-off-by: George Williams <george@nekls.org>
Signed-off-by: BWS Sandboxes <ByWaterSandboxes@gmail.com>

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Comment 5 Jonathan Druart 2017-12-11 14:37:52 UTC
Pushed to master for 18.05, thanks to everybody involved!
Comment 6 Nick Clemens 2017-12-14 18:18:40 UTC
Pushed to stable for 17.11.01, awesome work all!
Comment 7 Fridolin Somers 2017-12-21 09:58:54 UTC
Pushed to 17.05.x, will be in v17.05.07

This looks more bug than enhancement.