Summary: | Move template JavaScript to the footer: Serials, part 2 | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Josef Moravec <josef.moravec> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | josef.moravec, nick, testopia |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 19766 | ||
Bug Blocks: | 17858 | ||
Attachments: |
Bug 19761: Move template JavaScript to the footer: Serials, part 2
Bug 19761: Move template JavaScript to the footer: Serials, part 2 Bug 19761: Move template JavaScript to the footer: Serials, part 2 |
Description
Owen Leonard
2017-12-06 17:32:22 UTC
Created attachment 69620 [details] [review] Bug 19761: Move template JavaScript to the footer: Serials, part 2 This patch modifies more staff client serials templates so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of the modified templates: All button controls, DataTables functionality, tabs, etc. - Serials -> Subscription detail -> Edit routing list - Add recipients - Save - "Save and preview routing slip" should trigger preview - In preview popup: Print and Close buttons should work correctly Created attachment 69639 [details] [review] Bug 19761: Move template JavaScript to the footer: Serials, part 2 This patch modifies more staff client serials templates so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of the modified templates: All button controls, DataTables functionality, tabs, etc. - Serials -> Subscription detail -> Edit routing list - Add recipients - Save - "Save and preview routing slip" should trigger preview - In preview popup: Print and Close buttons should work correctly Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Created attachment 69789 [details] [review] Bug 19761: Move template JavaScript to the footer: Serials, part 2 This patch modifies more staff client serials templates so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of the modified templates: All button controls, DataTables functionality, tabs, etc. - Serials -> Subscription detail -> Edit routing list - Add recipients - Save - "Save and preview routing slip" should trigger preview - In preview popup: Print and Close buttons should work correctly Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Pushed to master for 18.05, thanks to everybody involved! Awesome work all! Enhancement, not backporting for 17.11 |