Summary: | 'Pickup library is different' message does not display library branch name when placing hold | ||
---|---|---|---|
Product: | Koha | Reporter: | Claire Gravely <claire_gravely> |
Component: | Hold requests | Assignee: | Claire Gravely <claire_gravely> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | gmcharlt, jonathan.druart, nick |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 15758 | ||
Bug Blocks: | |||
Attachments: |
When placing a hold for a patron whose pickup library and home library are different, the message displayed only shows the branch code and not the branch name.
Bug 19769: 'Pickup library is different' message does not display library branch name when placing hold Bug 19769: 'Pickup library is different' message does not display library branch name when placing hold |
Description
Claire Gravely
2017-12-07 07:31:13 UTC
Created attachment 69594 [details] [review] When placing a hold for a patron whose pickup library and home library are different, the message displayed only shows the branch code and not the branch name. This patch displays the branch name as well as the branch code. To test: 1. Search for an item 2. Click 'place hold' 3. Enter patron name/card number for a patron whose home library is different to the item's 4. Note the message displayed only shows the branch code but not the name 5. Apply Patch 6. Repeat 1-3 7. Message should not also display the branch name Created attachment 69605 [details] [review] Bug 19769: 'Pickup library is different' message does not display library branch name when placing hold When placing a hold for a patron whose pickup library and home library are different, the message displayed only shows the branch code and not the branch name. This patch displays the branch name as well as the branch code. To test: 1. Search for an item 2. Click 'place hold' 3. Enter patron name/card number for a patron whose home library is different to the item's 4. Note the message displayed only shows the branch code but not the name 5. Apply Patch 6. Repeat 1-3 7. Message should not also display the branch name https://bugs.koha-community.org/show_bug.cgi?id=19769 Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 69609 [details] [review] Bug 19769: 'Pickup library is different' message does not display library branch name when placing hold When placing a hold for a patron whose pickup library and home library are different, the message displayed only shows the branch code and not the branch name. This patch displays the branch name as well as the branch code. To test: 1. Search for an item 2. Click 'place hold' 3. Enter patron name/card number for a patron whose home library is different to the item's 4. Note the message displayed only shows the branch code but not the name 5. Apply Patch 6. Repeat 1-3 7. Message should now also display the branch name https://bugs.koha-community.org/show_bug.cgi?id=19769 Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Caused by commit df97814f3034a3d5015546c4eca21f08ae951e37 Bug 15758: Koha::Libraries - Remove GetBranches (certainly a bad merge conflict) Pushed to master for 18.05, thanks to everybody involved! Awesome work all! Pushed to stable for 17.11.01 |