| Summary: | Wrong success message if CHECKOUT_NOTE is not defined | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | Architecture, internals, and plumbing | Assignee: | Aleisha Amohia <aleisha> |
| Status: | ASSIGNED --- | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 17698 | ||
| Bug Blocks: | |||
|
Description
Jonathan Druart
2017-12-07 13:46:51 UTC
this will be fixed by the patch in bug 18915. *** This bug has been marked as a duplicate of bug 18915 *** Sorry Jonathan, I can't actually reproduce this. When there is no notice called 'CHECKOUT_NOTE' (which is now what the notice is called), the note still saves and the title shows as expected (but obviously the notice isn't sent and the log shows that "No circulation CHECKOUT_NOTE letter transported by email at /home/vagrant/kohaclone/C4/Letters.pm line 697." message) Aleisha, yes it is what I describe :) The message says "everything is ok and sent" whereas the email has not been sent. Maybe we should disable the feature if the notice template is not configured. Hi Jonathan, Sorry I think I'm understanding the problem now. I'll make a fix where the Checkout Notes feature can't be enabled unless the library also has a CHECKOUT_NOTE notice configured. Patch to come soon. Could there be a case where a library wants to activate the feature, but use it without email? We have some cases like the suggestions emails where you just delete the notice in that case. Maybe we could just adapt the text a little and remove the error/warning? Making the options dependent seems more hassle. (In reply to Katrin Fischer from comment #6) > Could there be a case where a library wants to activate the feature, but use > it without email? We have some cases like the suggestions emails where you > just delete the notice in that case. Maybe we could just adapt the text a > little and remove the error/warning? Making the options dependent seems more > hassle. I'm still working on the patch for Bug 17698 where the checkout notes will be shown on the staff dashboard, similar to how patron modifications are shown. I could add a patch to this bug that depends on 17698 where, if no notice is defined, it will not try to send an email and instead just show the note on the staff dashboard? hope that makes sense. (In reply to Aleisha Amohia from comment #7) > (In reply to Katrin Fischer from comment #6) > > Could there be a case where a library wants to activate the feature, but use > > it without email? We have some cases like the suggestions emails where you > > just delete the notice in that case. Maybe we could just adapt the text a > > little and remove the error/warning? Making the options dependent seems more > > hassle. > > I'm still working on the patch for Bug 17698 where the checkout notes will > be shown on the staff dashboard, similar to how patron modifications are > shown. I could add a patch to this bug that depends on 17698 where, if no > notice is defined, it will not try to send an email and instead just show > the note on the staff dashboard? hope that makes sense. Yep, makes sense to me! I have taken a look on bug 17698 and it looks promising. Linking both reports now. |