| Summary: | Case sensitivity is not preserved when creating local system preferences | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Frédéric Demians <f.demians> |
| Component: | System Administration | Assignee: | Frédéric Demians <f.demians> |
| Status: | CLOSED FIXED | QA Contact: | Kyle M Hall (khall) <kyle> |
| Severity: | trivial | ||
| Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, jonathan.druart, kyle, m.de.rooy, nick |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 19788 Local preference with uppercase
Bug 19788 Local preference with uppercase Bug 19788: Add a test Bug 19788 Local preference with uppercase Bug 19788: Add a test |
||
|
Description
Frédéric Demians
2017-12-11 07:25:24 UTC
Created attachment 69675 [details] [review] Bug 19788 Local preference with uppercase Fix a bug tranforming new local preference variable name in lowercase. TO TEST: 1. Admin > System preferences > Local use 2. Button New preference. Fill variable field with 'TESTfoo'. Click Save. 3. The new variable is named: 'testfoo'. 4. Apply the patch. 5. Button New preference. Fill variable field with 'TESTfoo2'. Click Save. 6. The new variable is properly named: 'TESTfoo2'. Created attachment 69676 [details] [review] Bug 19788 Local preference with uppercase Fix a bug tranforming new local preference variable name in lowercase. TO TEST: 1. Admin > System preferences > Local use 2. Button New preference. Fill variable field with 'TESTfoo'. Click Save. 3. The new variable is named: 'testfoo'. 4. Apply the patch. 5. Button New preference. Fill variable field with 'TESTfoo2'. Click Save. 6. The new variable is properly named: 'TESTfoo2'. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Who can provide me some more guarantee that we do not break things with this patch? Did you run all tests? Can you add a test? Created attachment 69912 [details] [review] Bug 19788: Add a test This patch makes sense to me. Created attachment 70041 [details] [review] Bug 19788 Local preference with uppercase Fix a bug tranforming new local preference variable name in lowercase. TO TEST: 1. Admin > System preferences > Local use 2. Button New preference. Fill variable field with 'TESTfoo'. Click Save. 3. The new variable is named: 'testfoo'. 4. Apply the patch. 5. Button New preference. Fill variable field with 'TESTfoo2'. Click Save. 6. The new variable is properly named: 'TESTfoo2'. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 70042 [details] [review] Bug 19788: Add a test Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Pushed to master for 18.05, thanks to everybody involved! Awesome work all, pushed to stable for 17.11.02 Pushed to 17.05.x for v17.05.08 |