|
Description
Patrick Robitaille
2017-12-12 18:24:09 UTC
Created attachment 69758 [details] [review] Bug 19801 - Display messages on user details page as well as on Check Out page To test: Look up a borrower, add a message (internal or opac) Click the Details tab for that borrower Messages should be displayed above the user information [is this the right place? it could go below] adding messages on this page should make them immediately available deleting messages on this page should delete them immediately and bring you back to the detail page. Basically, make sure messages work from both the Check out and detail pages and that there are no typos. Messages should work the same as they always have from the Check Out page. sponsored-by: Catalyst IT Created attachment 69798 [details] [review] Bug 19801 - Display messages on user details page as well as on Check Out page To test: Look up a borrower, add a message (internal or opac) Click the Details tab for that borrower Messages should be displayed above the user information [is this the right place? it could go below] adding messages on this page should make them immediately available deleting messages on this page should delete them immediately and bring you back to the detail page. Basically, make sure messages work from both the Check out and detail pages and that there are no typos. Messages should work the same as they always have from the Check Out page. sponsored-by: Catalyst IT Signed-off-by: Simon Pouchol <simon.pouchol@biblibre.com> QA comments:
Please fix indentation (moremember.pl lines 341 342 and 343)
if ( $input->param('from') == "moremember" )
# Always true. Use eq instead of ==
# This cause deleting a message from checkout page redirects to moremembers.pl
A quick note: we usually use the "messages" TT variables for warning or information messages to display on the screen.
Maybe it would be good to rename it ("patron_messages"?) to avoid confusion later.
Created attachment 70239 [details] [review] Bug 19801 - Fixes for QA - Fixes indentation - changes messages to patron_messages (even though it's not like that on the circulation page.) Patch tested with a sandbox, by Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> Created attachment 70362 [details] [review] Bug 18915: Giving CHECKOUT_NOTE access to issues table This patch allows the notice to reference the issues table so that the checkout note itself can be added to the note if wanted, such as in Comment 9. Sponsored-by: Catalyst IT Signed-off-by: Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> Created attachment 70363 [details] [review] Bug 18915: Renaming svc/patron_notes to svc/checkout_notes For consistency. Signed-off-by: Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> I removed the 2 previous patches. Sent to the wrong BZ Patch tested with a sandbox, by Marjorie Vila <marjorie.barry-vila@collecto.ca> Created attachment 70402 [details] [review] Bug 19801 - Display messages on user details page as well as on Check Out page To test: Look up a borrower, add a message (internal or opac) Click the Details tab for that borrower Messages should be displayed above the user information [is this the right place? it could go below] adding messages on this page should make them immediately available deleting messages on this page should delete them immediately and bring you back to the detail page. Basically, make sure messages work from both the Check out and detail pages and that there are no typos. Messages should work the same as they always have from the Check Out page. sponsored-by: Catalyst IT Signed-off-by: Simon Pouchol <simon.pouchol@biblibre.com> Signed-off-by: Marjorie Vila <marjorie.barry-vila@collecto.ca> Created attachment 70403 [details] [review] Bug 19801 - Fixes for QA - Fixes indentation - changes messages to patron_messages (even though it's not like that on the circulation page.) Signed-off-by: Marjorie Vila <marjorie.barry-vila@collecto.ca> Created attachment 71286 [details] [review] Bug 7143: Update about page for new dev - Jenny Way Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 71287 [details] [review] Bug 19801 - Display messages on user details page as well as on Check Out page To test: Look up a borrower, add a message (internal or opac) Click the Details tab for that borrower Messages should be displayed above the user information [is this the right place? it could go below] adding messages on this page should make them immediately available deleting messages on this page should delete them immediately and bring you back to the detail page. Basically, make sure messages work from both the Check out and detail pages and that there are no typos. Messages should work the same as they always have from the Check Out page. sponsored-by: Catalyst IT Signed-off-by: Simon Pouchol <simon.pouchol@biblibre.com> Signed-off-by: Marjorie Vila <marjorie.barry-vila@collecto.ca> Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com> Created attachment 71288 [details] [review] Bug 19801 - Fixes for QA - Fixes indentation - changes messages to patron_messages (even though it's not like that on the circulation page.) Signed-off-by: Marjorie Vila <marjorie.barry-vila@collecto.ca> Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com> Changing title for release notes to match patch description! I will accept the use of onclick here because it mimics what is done in another template, but keep in mind it is not allowed usually. Both patches will be squashed for readability. Created attachment 71365 [details] [review] Bug 19801 - Display messages on user details page as well as on Check Out page To test: Look up a borrower, add a message (internal or opac) Click the Details tab for that borrower Messages should be displayed above the user information [is this the right place? it could go below] adding messages on this page should make them immediately available deleting messages on this page should delete them immediately and bring you back to the detail page. Basically, make sure messages work from both the Check out and detail pages and that there are no typos. Messages should work the same as they always have from the Check Out page. sponsored-by: Catalyst IT Signed-off-by: Simon Pouchol <simon.pouchol@biblibre.com> Signed-off-by: Marjorie Vila <marjorie.barry-vila@collecto.ca> Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com> Patches squashed Pushed to master for 18.05, thanks to everybody involved! Hum, the layout looks wrong: https://screenshots.firefox.com/eZXcYk7RiZAjbsPQ/pro.kohadev.org I do not think the messages should be displayed on top of the patron's info. Moreover the "delete" link is missing. Awesome work all! Enhancement, not backported to stable. |