Bug 19802

Summary: Move Selenium code to its own module
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: Architecture, internals, and plumbingAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: mtompset
Version: unspecified   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on:    
Bug Blocks: 19243, 20757, 21479    
Attachments: Bug 19802: Move Selenium code to t::lib::Selenium
Bug 19802: Add stack trace to ease debugging
Bug 19802: [DO NOT PUSH] Generate screentshots
Bug 19802: Move Selenium code to t::lib::Selenium
Bug 19802: Add stack trace to ease debugging

Description Jonathan Druart 2017-12-12 22:15:02 UTC
To make it reusable easily
Comment 1 Jonathan Druart 2017-12-12 22:16:53 UTC
Created attachment 69756 [details] [review]
Bug 19802: Move Selenium code to t::lib::Selenium

To make it reusable easily.

Test plan:
The basic_workflow.t tests should still pass after this change.
Comment 2 Jonathan Druart 2017-12-26 17:43:35 UTC
Created attachment 70158 [details] [review]
Bug 19802: Add stack trace to ease debugging
Comment 3 Jonathan Druart 2017-12-26 17:43:40 UTC
Created attachment 70159 [details] [review]
Bug 19802: [DO NOT PUSH] Generate screentshots

This needs to be improved, but let as it for now.
Comment 4 Mark Tompsett 2018-01-19 02:53:07 UTC
Created attachment 70733 [details] [review]
Bug 19802: Move Selenium code to t::lib::Selenium

To make it reusable easily.

Test plan:
The basic_workflow.t tests should still pass after this change.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Comment 5 Mark Tompsett 2018-01-19 02:53:09 UTC
Created attachment 70734 [details] [review]
Bug 19802: Add stack trace to ease debugging

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Comment 6 Mark Tompsett 2018-01-19 02:53:47 UTC
prove before and after both pass, as expected. Code eyeballs well enough.
Comment 7 Jonathan Druart 2018-02-13 19:55:54 UTC
I am skipping QA, we need selenium tests to catch regressions.
Comment 8 Jonathan Druart 2018-02-13 19:56:03 UTC
Patches pushed to master for 18.05