Bug 19805

Summary: Add DataTables to Koha to MARC mapping page
Product: Koha Reporter: Owen Leonard <oleonard>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Marcel de Rooy <m.de.rooy>
Severity: enhancement    
Priority: P5 - low CC: m.de.rooy, nick, simon.pouchol
Version: Main   
Hardware: All   
OS: All   
URL: /cgi-bin/koha/admin/koha2marclinks.pl
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 19805: Add DataTables to Koha to MARC mapping page
Bug 19805: Add DataTables to Koha to MARC mapping page
Bug 19805: Add DataTables to Koha to MARC mapping page

Description Owen Leonard 2017-12-13 15:45:03 UTC
I think it would be useful to have sorting and filtering on the Koha to MARC mapping table.
Comment 1 Owen Leonard 2017-12-13 15:52:21 UTC
Created attachment 69779 [details] [review]
Bug 19805: Add DataTables to Koha to MARC mapping page

This patch adds sorting and filtering to the Koha to MARC mapping table
using DataTables.

Also changed: Font awesome icons on "Add" and "Remove" buttons; Minor
markup correction to breadcrumbs.

To test, apply the patch and go to Administration -> Koha to MARC
mapping.

- Table should be sorted by default on Koha field.
- Sorting and filtering should work correctly.
Comment 2 Simon Pouchol 2017-12-14 09:37:55 UTC
Created attachment 69793 [details] [review]
Bug 19805: Add DataTables to Koha to MARC mapping page

This patch adds sorting and filtering to the Koha to MARC mapping table
using DataTables.

Also changed: Font awesome icons on "Add" and "Remove" buttons; Minor
markup correction to breadcrumbs.

To test, apply the patch and go to Administration -> Koha to MARC
mapping.

- Table should be sorted by default on Koha field.
- Sorting and filtering should work correctly.

Signed-off-by: Simon Pouchol <simon.pouchol@biblibre.com>
Comment 3 Marcel de Rooy 2017-12-15 10:48:49 UTC
Created attachment 69819 [details] [review]
Bug 19805: Add DataTables to Koha to MARC mapping page

This patch adds sorting and filtering to the Koha to MARC mapping table
using DataTables.

Also changed: Font awesome icons on "Add" and "Remove" buttons; Minor
markup correction to breadcrumbs.

To test, apply the patch and go to Administration -> Koha to MARC
mapping.

- Table should be sorted by default on Koha field.
- Sorting and filtering should work correctly.

Signed-off-by: Simon Pouchol <simon.pouchol@biblibre.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Jonathan Druart 2017-12-18 15:19:26 UTC
Pushed to master for 18.05, thanks to everybody involved!
Comment 5 Nick Clemens (kidclamp) 2017-12-20 12:08:00 UTC
Awesome work all! Enhancement, not backporting for 17.11