| Summary: | invoice.pl warns about bad variable scope | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> | 
| Component: | Architecture, internals, and plumbing | Assignee: | Grace <gracesmythh> | 
| Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> | 
| Severity: | minor | ||
| Priority: | P5 - low | CC: | fridolin.somers, m.de.rooy, nick | 
| Version: | unspecified | Keywords: | Academy | 
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Crowdfunding goal: | 0 | 
| Patch complexity: | Trivial patch | Documentation contact: | |
| Documentation submission: | Text to go in the release notes: | ||
| Version(s) released in: | Circulation function: | ||
| Attachments: | Bug 19839: Removed Warning Bug 19839: Removed Warning | ||
| 
        
          Description
        
        
          Jonathan Druart
        
        
        
        
          2017-12-19 18:14:40 UTC
        
       Created attachment 70544 [details] [review] Bug 19839: Removed Warning Test Plan [1.] Check the patch to see that I have removed: $template->param( uncertainprices => 1 ); from line 204 as Mr Druart has instructed to do (to get to the patch see the comment above by Mr Druart) Created attachment 70552 [details] [review] Bug 19839: Removed Warning Test Plan [1.] Check the patch to see that I have removed: $template->param( uncertainprices => 1 ); from line 204 as Mr Druart has instructed to do (to get to the patch see the comment above by Mr Druart) Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed to master for 18.05, thanks to everybody involved! Awesome work all! Pushed to Stable for 17.11.02 Pushed to 17.05.x for v17.05.09 Less warn in logs saves trees ;) |