Summary: | reviews.datereviewed is not set | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | OPAC | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Kyle M Hall (khall) <kyle> |
Severity: | major | ||
Priority: | P5 - low | CC: | kyle, nick |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Bug Depends on: | 15839 | ||
Bug Blocks: | |||
Attachments: |
Bug 19843: (bug 15839 follow-up) Set reviews.datereviewed when the review is made
Bug 19843: (bug 15839 follow-up) Set reviews.datereviewed when the review is made Bug 19843: (bug 15839 follow-up) Set reviews.datereviewed when the review is made |
Description
Jonathan Druart
2017-12-19 19:53:14 UTC
Created attachment 69928 [details] [review] Bug 19843: (bug 15839 follow-up) Set reviews.datereviewed when the review is made Caused by commit 092ae340cef375cc66c8511fd34c1a4eec9c7ba6 Bug 15839: Koha::Reviews - Remove savereview the datereviewed=now() part of the query has not been translated. Test plan: Add a review from the OPAC Confirm that the reviews.datereviewd has been correctly set. Without this patch it is set to NULL. I have no idea how we could update existing data :-/ Created attachment 69948 [details] [review] Bug 19843: (bug 15839 follow-up) Set reviews.datereviewed when the review is made Caused by commit 092ae340cef375cc66c8511fd34c1a4eec9c7ba6 Bug 15839: Koha::Reviews - Remove savereview the datereviewed=now() part of the query has not been translated. Test plan: Add a review from the OPAC Confirm that the reviews.datereviewd has been correctly set. Without this patch it is set to NULL. I have no idea how we could update existing data :-/ Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 70000 [details] [review] Bug 19843: (bug 15839 follow-up) Set reviews.datereviewed when the review is made Caused by commit 092ae340cef375cc66c8511fd34c1a4eec9c7ba6 Bug 15839: Koha::Reviews - Remove savereview the datereviewed=now() part of the query has not been translated. Test plan: Add a review from the OPAC Confirm that the reviews.datereviewd has been correctly set. Without this patch it is set to NULL. I have no idea how we could update existing data :-/ Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Pushed to master for 18.05, thanks to everybody involved! Pushed to stable for 17.11.01, awesome work all! |