Summary: | HouseboundRoles.t is failing randomly | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Test Suite | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | fridolin.somers, nick |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Bug Depends on: | |||
Bug Blocks: | 25551 | ||
Attachments: |
Bug 19867: Prevent HouseboundRoles.t to fail randomly
Bug 19867: Prevent HouseboundRoles.t to fail randomly |
Description
Jonathan Druart
2017-12-21 17:35:13 UTC
Created attachment 70072 [details] [review] Bug 19867: Prevent HouseboundRoles.t to fail randomly Here is just a guess but we need to tell TestBuilder the values of housebound_deliverer and housebound_chooser to make sure it will not be 1 Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 70076 [details] [review] Bug 19867: Prevent HouseboundRoles.t to fail randomly Here is just a guess but we need to tell TestBuilder the values of housebound_deliverer and housebound_chooser to make sure it will not be 1 Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> I manually tested setting to the opposite values in the tests, and verified those values made the tests fail due to count problems. The fix is valid. Pushed to master for 18.05, thanks Tomas for the quick review! Awesome work all, pushed to stable for 17.11.02 Pushed to 17.05.x for v17.05.08 |