| Summary: | Move template JavaScript to the footer: UNIMARC editor plugins, part 3 | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | anne-claire.bernaudin, jonathan.druart, nick, sandboxes, testopia |
| Version: | Main | Keywords: | Academy |
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 19868 | ||
| Bug Blocks: | 17858, 19872 | ||
| Attachments: |
Bug 19869: Move template JavaScript to the footer: UNIMARC editor plugins, part 3
Bug 19869: Move template JavaScript to the footer: UNIMARC editor plugins, part 3 Bug 19869: Move template JavaScript to the footer: UNIMARC editor plugins, part 3 |
||
|
Description
Owen Leonard
2017-12-21 18:41:16 UTC
Created attachment 70080 [details] [review] Bug 19869: Move template JavaScript to the footer: UNIMARC editor plugins, part 3 This patch updates even more UNIMARC plugin templates so that JavaScript is included in the footer following the same pattern as other templates which have been modified to fix Bug 17858. To test you do not need a UNIMARC system. Apply the patch and for each plugin, configure a MARC subfield (e.g. 100$a) to use that plugin. From the MARC edit page, trigger the plugin and confirm that changes made in the popup window are saved to the corresponding field in the editor. - unimarc_field_123a.tt - unimarc_field_123d.tt - unimarc_field_123e.tt - unimarc_field_123f.tt - This template has been modified, but doesn't appear to be used. The unimarc_field_1234.pl script uses unimarc_field_123g.tt as its template. - unimarc_field_123g.tt - unimarc_field_123i_j.tt Hi Owen for 123$f, it works both with the unimarc_field_123f.pl and with the unimarc_field_123g.pl. Please note that I did not have a single plugin for $i and $j as I supposed reading : "- unimarc_field_123i_j.tt" On my sandbox (http://pro.user10-koha.sandbox.biblibre.eu) there were 2 different plugins unimarc_field_123i.pl and unimarc_field_123j.pl. Everything works well, so I sign it off :). Anne-Claire Patch tested with a sandbox, by Anne-Claire Bernaudin <anne-claire.bernaudin@univ-rennes1.fr> Created attachment 72994 [details] [review] Bug 19869: Move template JavaScript to the footer: UNIMARC editor plugins, part 3 This patch updates even more UNIMARC plugin templates so that JavaScript is included in the footer following the same pattern as other templates which have been modified to fix Bug 17858. To test you do not need a UNIMARC system. Apply the patch and for each plugin, configure a MARC subfield (e.g. 100$a) to use that plugin. From the MARC edit page, trigger the plugin and confirm that changes made in the popup window are saved to the corresponding field in the editor. - unimarc_field_123a.tt - unimarc_field_123d.tt - unimarc_field_123e.tt - unimarc_field_123f.tt - This template has been modified, but doesn't appear to be used. The unimarc_field_1234.pl script uses unimarc_field_123g.tt as its template. - unimarc_field_123g.tt - unimarc_field_123i_j.tt Signed-off-by: Anne-Claire Bernaudin <anne-claire.bernaudin@univ-rennes1.fr> Created attachment 73250 [details] [review] Bug 19869: Move template JavaScript to the footer: UNIMARC editor plugins, part 3 This patch updates even more UNIMARC plugin templates so that JavaScript is included in the footer following the same pattern as other templates which have been modified to fix Bug 17858. To test you do not need a UNIMARC system. Apply the patch and for each plugin, configure a MARC subfield (e.g. 100$a) to use that plugin. From the MARC edit page, trigger the plugin and confirm that changes made in the popup window are saved to the corresponding field in the editor. - unimarc_field_123a.tt - unimarc_field_123d.tt - unimarc_field_123e.tt - unimarc_field_123f.tt - This template has been modified, but doesn't appear to be used. The unimarc_field_1234.pl script uses unimarc_field_123g.tt as its template. - unimarc_field_123g.tt - unimarc_field_123i_j.tt Signed-off-by: Anne-Claire Bernaudin <anne-claire.bernaudin@univ-rennes1.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 18.05, thanks to everybody involved! Awesome work all, enhancement, not backported for stable |