Summary: | When & is in the title of a search result, subscribing via rss can be broken | ||
---|---|---|---|
Product: | Koha | Reporter: | Christophe Croullebois <christophe.croullebois> |
Component: | OPAC | Assignee: | Christophe Croullebois <christophe.croullebois> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | christophe.croullebois, jonathan.druart, katrin.fischer, roch.damour |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
patch
Bug 19875: escape & in rss feed |
Description
Christophe Croullebois
2017-12-22 14:32:04 UTC
Hi Christophe, do you plan to attach a patch? Created attachment 70155 [details] [review] patch thx to test (In reply to Jonathan Druart from comment #1) > Hi Christophe, do you plan to attach a patch? Hi Jonathan, done, thx I applied the patch, searched for results with a "&" in the title, and subscribed to the RSS feed. The feed show up, but I only get entrys up untill the records with the "&" in the title. After this records, nothing else show up. I followed the test plan, and I was wondering what do you meant by "subscribe is ok | nok"? (In reply to Roch D'Amour from comment #4) > I applied the patch, searched for results with a "&" in the title, and > subscribed to the RSS feed. The feed show up, but I only get entrys up > untill the records with the "&" in the title. After this records, nothing > else show up. I followed the test plan, and I was wondering what do you > meant by "subscribe is ok | nok"? Hello, what you describe is the result without patch =>nok Effectively if you have 10 result in the search and if a title with "&" is in the row 5, you'll see only the 5 firt rows. After applying the patch you'll see the 10 result and your subscribe must be ok (you can see links active in your browser). Hoping be clearer. Thx for your test Regards Created attachment 70911 [details] [review] Bug 19875: escape & in rss feed Hi Christophe, I am not sure why, but your change breaks the rendering of the RSS is in the browser for me. :( (In reply to Katrin Fischer from comment #7) > Hi Christophe, > > I am not sure why, but your change breaks the rendering of the RSS is in the > browser for me. :( Hi Katrin, in fact I had to close this one because now it is obsolete due to 19568 and his correction on 20286. I have seen when reporting 20286 that there is no more issues with the '&'. So I close this one, thx Katrine. |