Summary: | Add Novelist Select staff client profile | ||
---|---|---|---|
Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
Component: | Templates | Assignee: | Nick Clemens (kidclamp) <nick> |
Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | jonathan.druart, victor |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
This patch adds a new Staff Client profile for Novelist information. Previously we used the same value as the opac, this caused malformed links on the staff side. With this patch Novelist features will be disabled on the staff client until a correct profile is obtained from Novelist and entered into the system preference
|
Version(s) released in: | |
Circulation function: | |||
Bug Depends on: | 11606 | ||
Bug Blocks: | |||
Attachments: |
Bug 19882 - Add Novelist Select staff client profile
Bug 19882 - Add Novelist Select staff client profile Bug 19882 - Add Novelist Select staff client profile Bug 19882 - Add Novelist Select staff client profile Bug 19882: Add Novelist Select staff client profile Bug 19882: (follow-up) Add 'IGNORE' in DB update Bug 19882: Fix syntax issue in .pref file |
Description
Nick Clemens (kidclamp)
2017-12-27 12:45:04 UTC
Created attachment 70171 [details] [review] Bug 19882 - Add Novelist Select staff client profile This patchset allows for use of a separate Novelist profile for the staff client and opac. This allows Novelist to determine links and special styling for each. Testing is best with novelist credentials, however, confirming that values are set and used correctly and nothing is broken should suffice. To test: 1 - Apply patches 2 - Update database 3 - View detail pages for some records on opac and staff client and ensure no changes have been made 4 - Enable NovelistSelectStaffEnabled (and enter or have info in the Profile and password) 5 - Set NovelistSelectStaffView to 'above' 6 - View detail pages for some records, verify that if novelist info is available it is displayed and nothing is displayed if not 7 - Repeat with all staff view options conflicts: ~/d/koha ❯❯❯ git bz apply 19882 Bug 19882 - Add Novelist Select staff client profile 70171 - Bug 19882 - Add Novelist Select staff client profile Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 19882 - Add Novelist Select staff client profile Using index info to reconstruct a base tree... M installer/data/mysql/sysprefs.sql M koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt Auto-merging installer/data/mysql/sysprefs.sql error: Failed to merge in the changes. Patch failed at 0001 Bug 19882 - Add Novelist Select staff client profile The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-19882---Add-Novelist-Select-staff-client-profi-lR7BtR.patch Created attachment 72718 [details] [review] Bug 19882 - Add Novelist Select staff client profile This patchset allows for use of a separate Novelist profile for the staff client and opac. This allows Novelist to determine links and special styling for each. Testing is best with novelist credentials, however, confirming that values are set and used correctly and nothing is broken should suffice. To test: 1 - Apply patches 2 - Update database 3 - View detail pages for some records on opac and staff client and ensure no changes have been made 4 - Enable NovelistSelectStaffEnabled (and enter or have info in the Profile and password) 5 - Set NovelistSelectStaffView to 'above' 6 - View detail pages for some records, verify that if novelist info is available it is displayed and nothing is displayed if not 7 - Repeat with all staff view options I tested this with my library's Novelist credentials and it's working well. The only problem I see is a fail from the QA tools: [% KOHA_VERSION %] is removed by the patch. Created attachment 72882 [details] [review] Bug 19882 - Add Novelist Select staff client profile This patchset allows for use of a separate Novelist profile for the staff client and opac. This allows Novelist to determine links and special styling for each. Testing is best with novelist credentials, however, confirming that values are set and used correctly and nothing is broken should suffice. To test: 1 - Apply patches 2 - Update database 3 - View detail pages for some records on opac and staff client and ensure no changes have been made 4 - Enable NovelistSelectStaffEnabled (and enter or have info in the Profile and password) 5 - Set NovelistSelectStaffView to 'above' 6 - View detail pages for some records, verify that if novelist info is available it is displayed and nothing is displayed if not 7 - Repeat with all staff view options (In reply to Owen Leonard from comment #4) > The only problem I see is a fail from the QA tools: [% KOHA_VERSION %] is > removed by the patch. I think this fail is a bug in the qa tools. We don't use [% KOHA_VERSION %] with third-party assets. Created attachment 72918 [details] [review] Bug 19882 - Add Novelist Select staff client profile This patchset allows for use of a separate Novelist profile for the staff client and opac. This allows Novelist to determine links and special styling for each. Testing is best with novelist credentials, however, confirming that values are set and used correctly and nothing is broken should suffice. To test: 1 - Apply patches 2 - Update database 3 - View detail pages for some records on opac and staff client and ensure no changes have been made 4 - Enable NovelistSelectStaffEnabled (and enter or have info in the Profile and password) 5 - Set NovelistSelectStaffView to 'above' 6 - View detail pages for some records, verify that if novelist info is available it is displayed and nothing is displayed if not 7 - Repeat with all staff view options Signed-off-by: Owen Leonard <oleonard@myacpl.org> Comment on attachment 72918 [details] [review] Bug 19882 - Add Novelist Select staff client profile Review of attachment 72918 [details] [review]: ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt @@ +1025,5 @@ > verify_images(); > });[% END %] > </script> > + [% IF ( Koha.Preference('NovelistSelectStaffEnabled') && Koha.Preference('NovelistSelectStaffProfile') && ( normalized_isbn || normalized_upc ) ) %] > + <script type="text/javascript" src="https://imageserver.ebscohost.com/novelistselect/ns2init.js"></script> External Javascript, so this is ok. FAIL koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt FAIL forbidden patterns forbidden pattern: Include [% KOHA_VERSION %] in js paths (bug 12904) - May be false positive (line 1049) Created attachment 74084 [details] [review] Bug 19882: Add Novelist Select staff client profile This patchset allows for use of a separate Novelist profile for the staff client and opac. This allows Novelist to determine links and special styling for each. Testing is best with novelist credentials, however, confirming that values are set and used correctly and nothing is broken should suffice. To test: 1 - Apply patches 2 - Update database 3 - View detail pages for some records on opac and staff client and ensure no changes have been made 4 - Enable NovelistSelectStaffEnabled (and enter or have info in the Profile and password) 5 - Set NovelistSelectStaffView to 'above' 6 - View detail pages for some records, verify that if novelist info is available it is displayed and nothing is displayed if not 7 - Repeat with all staff view options Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> 1. IGNORE is missing (I can do it when pushing, but...) 2. We should set NovelistSelectStaffProfile=NovelistSelectProfile, right? Created attachment 74103 [details] [review] Bug 19882: (follow-up) Add 'IGNORE' in DB update 1 - Added :-) 2 - That is the problem right now - using the regular profile makes all links point over to the opac and so they don't work properly. I can add to the release notes as I think disabling it until they add a profile is better Pushed to master for 18.05, thanks to everybody involved! Created attachment 74239 [details] [review] Bug 19882: Fix syntax issue in .pref file The translate script raised an error: Use of uninitialized value $pref_name in concatenation (.) or string at LangInstaller.pm line 190. Last patch pushed to master. Enhancement, not backported for 17.11.x |