|
Description
Katrin Fischer
2017-12-29 06:53:22 UTC
Created attachment 70660 [details] [review] Bug 19892: Replace numbersphr variable with Koha.Preference('OPACNumbersPreferPhrase') in OPAC Test Case 1) Check that the following files have been changed properly. opac/opac-search.pl opac/opac-main.pl koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt 2)Apply bug 3) Check that there are no differences in behaviour as a result of the patch. Created attachment 73061 [details] [review] Bug 19892: Replace numbersphr variable with Koha.Preference('OPACNumbersPreferPhrase') in OPAC Test Case 1) Check that the following files have been changed properly. opac/opac-search.pl opac/opac-main.pl koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt 2)Apply bug 3) Check that there are no differences in behaviour as a result of the patch. Signed-off-by: Roch D'Amour <roch.damour@inlibro.com> Created attachment 73076 [details] [review] Bug 19892: Replace numbersphr variable with Koha.Preference('OPACNumbersPreferPhrase') in OPAC Test Case 1) Check that the following files have been changed properly. opac/opac-search.pl opac/opac-main.pl koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt 2)Apply bug 3) Check that there are no differences in behaviour as a result of the patch. Signed-off-by: Roch D'Amour <roch.damour@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> What about this occurrence? koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc: [% IF ( numbersphr ) %] koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc: [% END # /numbersphr %] Created attachment 73338 [details] [review] Bug 19892 (follow-up) Replace one more instance This patch replaces one more instance of [% IF ( numbersphr ) %]. To test, apply the patch and view the source of the OPAC home page. With the OPACNumbersPreferPhrase system preference set to 'use,' you should find this in the HTML source: <option value="callnum,phr">Call number</option> With the preference set to 'don't use,' you should find this: <option value="callnum">Call number</option> Created attachment 73506 [details] [review] Bug 19892: Replace numbersphr variable with Koha.Preference('OPACNumbersPreferPhrase') in OPAC Test Case 1) Check that the following files have been changed properly. opac/opac-search.pl opac/opac-main.pl koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt 2)Apply bug 3) Check that there are no differences in behaviour as a result of the patch. Signed-off-by: Roch D'Amour <roch.damour@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 73507 [details] [review] Bug 19892 (follow-up) Replace one more instance This patch replaces one more instance of [% IF ( numbersphr ) %]. To test, apply the patch and view the source of the OPAC home page. With the OPACNumbersPreferPhrase system preference set to 'use,' you should find this in the HTML source: <option value="callnum,phr">Call number</option> With the preference set to 'don't use,' you should find this: <option value="callnum">Call number</option> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Treating as a QA follow-up. Pushed to master for 18.05, thanks to everybody involved! Enhancement, not backporting to 17.11.x Pushed to stable for 17.11.06 Awesome work all! Okay, I changed my mind and pushed, not sure how to get back to 'Pushed to stable' (In reply to Nick Clemens from comment #12) > Okay, I changed my mind and pushed, not sure how to get back to 'Pushed to > stable' Leave it resolved since I will not push to 17.05.x |