Bug 19899

Software Error while upgrade from KOHA 16.05 to 17.11. This error while check in and I got error message "The method noreturn is not covered by tests!"

Anybody can help?

Hi Mohd,

How did you install Koha? Are you sure it is not a customized version of Koha?

What returns the following commands?
  cd /usr/share/koha; grep -r noreturn | grep -v translator

I do not find any relevant occurrences of "noreturn" in our code that could produce such error.

Do you have something else in the Koha log file?

Fresh install koha using this instruction: https://wiki.koha-community.org/wiki/Koha_on_ubuntu_-_packages

After install, I restore old database (from KOHA 16.05).

And then upgrade schema "koha-upgrade-schema {instance}"

Last reindex "koha-rebuild-zebra -v -f {instance}"

Return from command

lib/C4/Circulation.pm:  noreturn: do not return, let item remain where checked in (floating collections)
lib/C4/Circulation.pm:        # if $hbr was "noreturn" or any other non-item table value, then it should 'float' (i.e. stay at this branch)
intranet/htdocs/intranet-tmpl/prog/en/modules/admin/smart-rules.tt:                            [% IF ( default_returnbranch == 'noreturn' ) %]
intranet/htdocs/intranet-tmpl/prog/en/modules/admin/smart-rules.tt:                            <option value="noreturn" selected="selected">
intranet/htdocs/intranet-tmpl/prog/en/modules/admin/smart-rules.tt:                            <option value="noreturn">
intranet/htdocs/intranet-tmpl/prog/en/modules/admin/smart-rules.tt:                            [% ELSIF ( branch_item_rule_loo.returnbranch == 'noreturn' ) %]
intranet/htdocs/intranet-tmpl/prog/en/modules/admin/smart-rules.tt:                            <option value="noreturn">Item floats</option>
intranet/cgi-bin/installer/data/mysql/kohastructure.sql:  `returnbranch` varchar(15) default NULL, -- the branch the item returns to (homebranch, holdingbranch, noreturn)
man/man3/C4::Circulation.3pm:  noreturn: do not return, let item remain where checked in (floating collections)

Do you have something else in the Koha log file?

I will need the file and line number where the error occurs.

Ok I recreate the problem, it happens when "Return policy" is "Item floats" (value noreturn) in circ rules.

Certainly caused by commit 6eade474ed3a84a5ba372a26ac27bf9fb4bd2299
Bug 18276: Remove GetBiblioFromItemNumber - Easy ones

Created attachment 70290 [details] [review]
Bug 19899: Restore Item floats feature - do not crash

Error is "The method noreturn is not covered by tests!"
caused by commit 6eade474ed3a84a5ba372a26ac27bf9fb4bd2299
Bug 18276: Remove GetBiblioFromItemNumber - Easy ones

When the "Return policy" (var returnbranch) is set to "Item floats" (value noreturn)
the library must be the current library (from userenv).
This behaviour is used in C4::Circulation::AddReturn

On bug 18276 I assumed that the value was either holdingbranch or
homebranch, and forgot it could be "noreturn"

Test plan:
Set Return policy to Item floats
Check an item in
=> without this patch it explodes
=> With this patch applied it will check the item in

Created attachment 70316 [details]
Error after edit code line 279

After edit code at line 279, the error like attachment

Hi Mohd, did you manually edit the files or apply the patches?

Hm, you could try adding a ; to the end of this line:
$returnbranch = $hbr eq 'noreturn' ? $item->$hbr : $userenv_branch;

I manually edit the files, after add semicolon, error same "manually edit the files"

How to apply the patches?

Oops indeed, there is a semicolon missing at the end. I am going to reattach a patch.

Created attachment 70317 [details] [review]
Bug 19899: Restore Item floats feature - do not crash

Error is "The method noreturn is not covered by tests!"
caused by commit 6eade474ed3a84a5ba372a26ac27bf9fb4bd2299
Bug 18276: Remove GetBiblioFromItemNumber - Easy ones

When the "Return policy" (var returnbranch) is set to "Item floats" (value noreturn)
the library must be the current library (from userenv).
This behaviour is used in C4::Circulation::AddReturn

On bug 18276 I assumed that the value was either holdingbranch or
homebranch, and forgot it could be "noreturn"

Test plan:
Set Return policy to Item floats
Check an item in
=> without this patch it explodes
=> With this patch applied it will check the item in

Created attachment 70318 [details]
Successful fix the problem, thank you

Your code has been successful fix the problem. Now I can return my book easier.

Thank you all

Thanks Mohd for the confirmation.

You should read this wiki page (https://wiki.koha-community.org/wiki/Sign_off_on_patches) to know how to apply patches (using git-bz) and learn how to sign off on these patches.

Patch tested with a sandbox, by Mohd Hafiz Yusoff <mhby87@gmail.com>

Created attachment 70319 [details] [review]
Bug 19899: Restore Item floats feature - do not crash

Error is "The method noreturn is not covered by tests!"
caused by commit 6eade474ed3a84a5ba372a26ac27bf9fb4bd2299
Bug 18276: Remove GetBiblioFromItemNumber - Easy ones

When the "Return policy" (var returnbranch) is set to "Item floats" (value noreturn)
the library must be the current library (from userenv).
This behaviour is used in C4::Circulation::AddReturn

On bug 18276 I assumed that the value was either holdingbranch or
homebranch, and forgot it could be "noreturn"

Test plan:
Set Return policy to Item floats
Check an item in
=> without this patch it explodes
=> With this patch applied it will check the item in

Signed-off-by: Mohd Hafiz Yusoff <mhby87@gmail.com>

Created attachment 70332 [details] [review]
Bug 19899: Restore Item floats feature - do not crash

Error is "The method noreturn is not covered by tests!"
caused by commit 6eade474ed3a84a5ba372a26ac27bf9fb4bd2299
Bug 18276: Remove GetBiblioFromItemNumber - Easy ones

When the "Return policy" (var returnbranch) is set to "Item floats" (value noreturn)
the library must be the current library (from userenv).
This behaviour is used in C4::Circulation::AddReturn

On bug 18276 I assumed that the value was either holdingbranch or
homebranch, and forgot it could be "noreturn"

Test plan:
Set Return policy to Item floats
Check an item in
=> without this patch it explodes
=> With this patch applied it will check the item in

Signed-off-by: Mohd Hafiz Yusoff <mhby87@gmail.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Pushed to master for 18.05, thanks to everybody involved!

Awesome work all, pushed to stable for 17.11.02

Bug 18276 not in 17.05.x