|
Description
Josef Moravec
2018-01-02 07:11:24 UTC
Created attachment 70220 [details] [review] Bug 19902: Add column settings to bibliographic record checkouts history table Test plan: 0) Apply the patch 1) Go to administration -> Configure columns, note there is new checkoutshistory-table in Catalogue section 2) Make some configuration in this table settings 3) Go to detail of any record -> Checkout history 4) The columns should be visible according to your configuration from step 2 5) Play with Column visibility, to ensure it does work as it should I did not succeed in hiding any column of the table. I tried on other tables (example check in table) and it worked fine so I think it is trully a problem with this patch. Created attachment 75642 [details] [review] Bug 19902: Add column settings to bibliographic record checkouts history table Test plan: 0) Apply the patch 1) Go to administration -> Configure columns, note there is new checkoutshistory-table in Catalogue section 2) Make some configuration in this table settings 3) Go to detail of any record -> Checkout history 4) The columns should be visible according to your configuration from step 2 5) Play with Column visibility, to ensure it does work as it should Signed-off-by: Owen Leonard <oleonard@myacpl.org> Fixed a minor typo during signoff. Turn off intranetreadinghistory => boom! Created attachment 76369 [details] [review] Bug 19902: (follow-up) Deal with patron column regarding on intranetreadinghistory setting Test plan: Try it with intranetreadinghistory allowed and not allowed and it should still work in both cases (In reply to Jonathan Druart from comment #4) > Turn off intranetreadinghistory > => boom! Thanks for catching this! Created attachment 76420 [details] [review] Bug 19902: Add column settings to bibliographic record checkouts history table Test plan: 0) Apply the patch 1) Go to administration -> Configure columns, note there is new checkoutshistory-table in Catalogue section 2) Make some configuration in this table settings 3) Go to detail of any record -> Checkout history 4) The columns should be visible according to your configuration from step 2 5) Play with Column visibility, to ensure it does work as it should Signed-off-by: Owen Leonard <oleonard@myacpl.org> Fixed a minor typo during signoff. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 76421 [details] [review] Bug 19902: (follow-up) Deal with patron column regarding on intranetreadinghistory setting Test plan: Try it with intranetreadinghistory allowed and not allowed and it should still work in both cases Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Awesome work all! Pushed to master for 18.11 Enhancement, will not be backported to 18.05.x series. |