Bug 19914

Summary: Cannot locate the "Delete" in the library list table
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: Test SuiteAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: minor    
Priority: P5 - low CC: fridolin.somers, nick
Version: unspecified   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 19560    
Bug Blocks: 19243    
Attachments: Bug 19914: Add an id to the Delete button on the library list view
Bug 19914: Add an id to the Delete button on the library list view
Bug 19914: Add an id to the Delete button on the library list view

Description Jonathan Druart 2018-01-04 13:23:39 UTC
On the library list table, a link (href=/cgi-bin/koha/admin/branches.pl?op=delete_confirm&amp;branchcode=[% library.branchcode %]") has been replaced with a button (on bug 19560).

On bug 19243 (Selenium tests) we need an easy way to locate this button, so we should add an id to this element.
Comment 1 Jonathan Druart 2018-01-04 13:29:07 UTC
Created attachment 70267 [details] [review]
Bug 19914: Add an id to the Delete button on the library list view

To ease selenium tests, see bug 19243.
Comment 2 Owen Leonard 2018-01-04 14:42:07 UTC
Created attachment 70273 [details] [review]
Bug 19914: Add an id to the Delete button on the library list view

To ease selenium tests, see bug 19243.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Nick Clemens 2018-01-08 17:02:59 UTC
Created attachment 70329 [details] [review]
Bug 19914: Add an id to the Delete button on the library list view

To ease selenium tests, see bug 19243.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 4 Nick Clemens 2018-01-08 17:03:23 UTC
I added a space for readability
Comment 5 Jonathan Druart 2018-01-09 12:55:32 UTC
Pushed to master for 18.05, thanks to everybody involved!
Comment 6 Nick Clemens 2018-01-15 16:48:18 UTC
Awesome work all, pushed to stable for 17.11.02
Comment 7 Fridolin Somers 2018-01-25 09:56:16 UTC
Pushed to 17.05.x for v17.05.09