|
Description
Nick Clemens (kidclamp)
2018-01-11 18:19:09 UTC
Created attachment 70439 [details] [review] Bug 19957 - Allow continued editing of report after saving To test: 1 - Edit or create a report 2 - Save it 3 - Note the report is saved but you can't keep editing 4 - Clicking 'Edit' returns you to editing 5 - Apply patch 6 - Save report 7 - Note success message remains, but report is still open for editing 8 - Try again after inserting erros into report (No Select, bad authorised value, etc.) 9 - Note errors stil display as expected Created attachment 70443 [details] [review] Bug 19957 - Hide saved message once editing report To test: 1 - Apply this patch 2 - Save/Update report 3 - Note when you focus on the 'sql' area the saved message dissappears I don't think it's necessary to show all the links from the old confirmation page. They're all in the toolbar or the sidebar. I would prefer that we instead put a standard "message" type dialog saying "Your report has been saved." Created attachment 70604 [details] [review] Bug 19957 - Allow continued editing of report after saving To test: 1 - Edit or create a report 2 - Save it 3 - Note the report is saved but you can't keep editing 4 - Clicking 'Edit' returns you to editing 5 - Apply patch 6 - Save report 7 - Note success message remains, but report is still open for editing 8 - Note when you click the saved/updated message dissappears 9 - Try again after inserting erros into report (No Select, bad authorised value, etc.) 10 - Note errors stil display as expected 11 - Verify message works on update of existing report and save of new report11 - Verify message works on update of existing report and save of new report11 - Verify message works on update of existing report and save of new report11 - Verify message works on update of existing report and save of new report11 - Verify message works on update of existing report and save of new report11 - Verify message works on update of existing report and save of new report11 - Verify message works on update of existing report and save of new report11 - Verify message works on update of existing report and save of new report11 - Verify message works on update of existing report and save of new report11 - Verify message works on update of existing report and save of new report11 - Verify message works on update of existing report and save of new report Created attachment 70605 [details] [review] Bug 19957 - Allow continued editing of report after saving To test: 1 - Edit or create a report 2 - Save it 3 - Note the report is saved but you can't keep editing 4 - Clicking 'Edit' returns you to editing 5 - Apply patch 6 - Save report 7 - Note success message remains, but report is still open for editing 8 - Note when you click the saved/updated message dissappears 9 - Try again after inserting erros into report (No Select, bad authorised value, etc.) 10 - Note errors stil display as expected 11 - Verify message works on update of existing report and save of new new report The message dialog should replace "<div class="alert alert-info">" ...with... <div class="dialog message"> Created attachment 70767 [details] [review] Bug 19957 - Allow continued editing of report after saving To test: 1 - Edit or create a report 2 - Save it 3 - Note the report is saved but you can't keep editing 4 - Clicking 'Edit' returns you to editing 5 - Apply patch 6 - Save report 7 - Note success message remains, but report is still open for editing 8 - Note when you click the saved/updated message dissappears 9 - Try again after inserting erros into report (No Select, bad authorised value, etc.) 10 - Note errors stil display as expected 11 - Verify message works on update of existing report and save of new new report Created attachment 70769 [details] [review] Bug 19957 - Allow continued editing of report after saving To test: 1 - Edit or create a report 2 - Save it 3 - Note the report is saved but you can't keep editing 4 - Clicking 'Edit' returns you to editing 5 - Apply patch 6 - Save report 7 - Note success message remains, but report is still open for editing 8 - Note when you click the saved/updated message dissappears 9 - Try again after inserting erros into report (No Select, bad authorised value, etc.) 10 - Note errors stil display as expected 11 - Verify message works on update of existing report and save of new new report Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 70776 [details] [review] Bug 19957 - Allow continued editing of report after saving To test: 1 - Edit or create a report 2 - Save it 3 - Note the report is saved but you can't keep editing 4 - Clicking 'Edit' returns you to editing 5 - Apply patch 6 - Save report 7 - Note success message remains, but report is still open for editing 8 - Note when you click the saved/updated message dissappears 9 - Try again after inserting erros into report (No Select, bad authorised value, etc.) 10 - Note errors stil display as expected 11 - Verify message works on update of existing report and save of new new report Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Charles Farmer <charles.farmer@inLibro.com> Passes qa1. Works as advertised: I was sent back to editing the form after a modification, and the behaviour of the controller when saving an erroneous SQL is kept as is. At first I was a little irritated, but as the toolbar gives you all the options here, I think the returning to the edit form works for this page. Created attachment 73242 [details] [review] Bug 19957: Allow continued editing of report after saving To test: 1 - Edit or create a report 2 - Save it 3 - Note the report is saved but you can't keep editing 4 - Clicking 'Edit' returns you to editing 5 - Apply patch 6 - Save report 7 - Note success message remains, but report is still open for editing 8 - Note when you click the saved/updated message dissappears 9 - Try again after inserting erros into report (No Select, bad authorised value, etc.) 10 - Note errors stil display as expected 11 - Verify message works on update of existing report and save of new new report Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Charles Farmer <charles.farmer@inLibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Current patch-complexity: Trivial patch Pushed to master for 18.05, thanks to everybody involved! Enhancement, not backported for stable |