Summary: | Move template JavaScript to the footer: Patron card creator | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | testopia |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 17858 | ||
Attachments: |
Bug 19961: Move template JavaScript to the footer: Patron card creator
Bug 19961: Move template JavaScript to the footer: Patron card creator Bug 19961: Move template JavaScript to the footer: Patron card creator |
Description
Owen Leonard
2018-01-11 19:05:48 UTC
Created attachment 72096 [details] [review] Bug 19961: Move template JavaScript to the footer: Patron card creator This patch modifies the staff client patron card creator templates so that JavaScript is included in the footer instead of the header. Also changed: Removed "type" attribute from script tags. To test, apply the patch and test the JavaScript-driven features of each modified template: All button controls, DataTables functionality, form validation, etc. - Creating and managing layouts - Creating and managing card batches - Creating and managing card templates - Creating and managing printer profiles - Creating and managing images Created attachment 72904 [details] [review] Bug 19961: Move template JavaScript to the footer: Patron card creator This patch modifies the staff client patron card creator templates so that JavaScript is included in the footer instead of the header. Also changed: Removed "type" attribute from script tags. To test, apply the patch and test the JavaScript-driven features of each modified template: All button controls, DataTables functionality, form validation, etc. - Creating and managing layouts - Creating and managing card batches - Creating and managing card templates - Creating and managing printer profiles - Creating and managing images Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com> Created attachment 73246 [details] [review] Bug 19961: Move template JavaScript to the footer: Patron card creator This patch modifies the staff client patron card creator templates so that JavaScript is included in the footer instead of the header. Also changed: Removed "type" attribute from script tags. To test, apply the patch and test the JavaScript-driven features of each modified template: All button controls, DataTables functionality, form validation, etc. - Creating and managing layouts - Creating and managing card batches - Creating and managing card templates - Creating and managing printer profiles - Creating and managing images Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 18.05, thanks to everybody involved! |