Bug 19962

Summary: Introduce koha-sip to replace koha-*-sip
Product: Koha Reporter: Pongtawat <pongtawat>
Component: Command-line UtilitiesAssignee: Pongtawat <pongtawat>
Status: RESOLVED DUPLICATE QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: magnus, robin
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: --- Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: Bug 19962 - Introduce koha-sip to replace koha-*-sip
Bug 19962 - Introduce koha-sip to replace koha-*-sip

Description Pongtawat 2018-01-12 10:06:34 UTC
Introduce a new koha-sip script which use new command style (as koha-plack, etc) to replace old set of SIP commands.

Also add an ability to disable SIP.
Comment 1 Pongtawat 2018-01-12 10:14:38 UTC
Created attachment 70458 [details]
Bug 19962 - Introduce koha-sip to replace koha-*-sip
Comment 2 Pongtawat 2018-01-12 10:19:03 UTC
To test:

- Apply this patch
- koha-sip --start koha1  => same as koha-start-sip koha1
- koha-sip --stop koha1 => same as koha-stop-sip koha1
- koha-sip --restart koha1 => same as koha-stop-sip koha1 && koha-start-sip koha1
- koha-sip --enable koha1 => same as koha-enable-sip koha1
- koha-sip --disable koha1 => new, move SIP config file

Note:
- stop use start-stop-daemon (same as koha-plack) to make sure it really stop
- enable and disable is a bit different from koha-plack. It will continue even if some instances are already enabled (or disabled). In contrast, koha-plack --enable will just stop at the instance that was already enabled without processing the following instances.
Comment 3 Pongtawat 2018-01-12 10:24:43 UTC
Created attachment 70459 [details] [review]
Bug 19962 - Introduce koha-sip to replace koha-*-sip
Comment 4 Magnus Enger 2019-03-19 08:05:29 UTC
A koha-sip script has already been pushed to master as part of bug 18562.

*** This bug has been marked as a duplicate of bug 18562 ***