Summary: | Local Use tab in systempreferences tries to open text editor's temporary files, and die | ||
---|---|---|---|
Product: | Koha | Reporter: | Julian Maurice <julian.maurice> |
Component: | System Administration | Assignee: | Julian Maurice <julian.maurice> |
Status: | CLOSED FIXED | QA Contact: | Nick Clemens (kidclamp) <nick> |
Severity: | normal | ||
Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, mtompset, nick |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 19977: Open only .pref files in Local Use tab (sysprefs)
Bug 19977: Open only .pref files in Local Use tab (sysprefs) Bug 19977: Open only .pref files in Local Use tab (sysprefs) |
Description
Julian Maurice
2018-01-16 09:19:26 UTC
Created attachment 70548 [details] [review] Bug 19977: Open only .pref files in Local Use tab (sysprefs) Test plan: 1. Open .../prog/en/modules/admin/preferences/circulation.pref with vim (check that it creates a .circulation.pref.swp in the same directory) 2. Go to the "Local Use" tab in admin/systempreferences.pl 3. Confirm that the page works normally One would hope this case never happens. And if it does, stop editing the files on a live system. That being said, this is a straight-forward regexp tightening. Created attachment 70703 [details] [review] Bug 19977: Open only .pref files in Local Use tab (sysprefs) Test plan: 1. Open .../prog/en/modules/admin/preferences/circulation.pref with vim (check that it creates a .circulation.pref.swp in the same directory) 2. Go to the "Local Use" tab in admin/systempreferences.pl 3. Confirm that the page works normally Signed-off-by: Mark Tompsett <mtompset@hotmail.com> (In reply to M. Tompsett from comment #2) > One would hope this case never happens. And if it does, stop editing the > files on a live system. That being said, this is a straight-forward regexp > tightening. Of course this should never happen in production, but it can be annoying during development. Thanks for the sign-off! Created attachment 70749 [details] [review] Bug 19977: Open only .pref files in Local Use tab (sysprefs) Test plan: 1. Open .../prog/en/modules/admin/preferences/circulation.pref with vim (check that it creates a .circulation.pref.swp in the same directory) 2. Go to the "Local Use" tab in admin/systempreferences.pl 3. Confirm that the page works normally Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Pushed to master for 18.05, thanks to everybody involved! Awesome work all! Pushed to Stable for 17.11.02 Pushed to 17.05.x for v17.05.09 |