Summary: | Switch single-column templates to Bootstrap grid: Authorities | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | claire_gravely, josef.moravec, roch.damour, testopia |
Version: | Main | Keywords: | Academy |
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 19785, 19786 | ||
Bug Blocks: | 19980 | ||
Attachments: |
Bug 19983: Switch single-column templates to Bootstrap grid: Authorities
Bug 19983: Switch single-column templates to Bootstrap grid: Authorities Bug 19983: Switch single-column templates to Bootstrap grid: Authorities Bug 19983: Switch single-column templates to Bootstrap grid: Authorities |
Description
Owen Leonard
2018-01-16 17:29:44 UTC
Created attachment 70693 [details] [review] Bug 19983: Switch single-column templates to Bootstrap grid: Authorities This patch updates several single-column Authorities module templates to use the Bootstrap grid. - authorities-home - The home page of the Authorities module. - authorities.tt - The authority add/edit page. - blinddetail-biblio-search.tt - Not really testable -- It's the small popup window which appears during the process of linking an authority to a MARC record. - detail.tt - The authority detail page. Search for an authority record and click on the "details" link in the search results. - merge.tt - From a list of authority search results, select "Merge" from the Actions menu of two authority records. Test both the initial selection screen and the source/destination merging view. - searchresultlist.tt - The authority search results page. Each of these pages should look correct, with a single centered column with wide margins on either side. At lower browser widths the margins should disappear. Patch does not apply fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/authorities/detail.tt). This applies cleanly for me (after some auto-merging). Can you try again? Created attachment 72510 [details] [review] Bug 19983: Switch single-column templates to Bootstrap grid: Authorities This patch updates several single-column Authorities module templates to use the Bootstrap grid. - authorities-home - The home page of the Authorities module. - authorities.tt - The authority add/edit page. - blinddetail-biblio-search.tt - Not really testable -- It's the small popup window which appears during the process of linking an authority to a MARC record. - detail.tt - The authority detail page. Search for an authority record and click on the "details" link in the search results. - merge.tt - From a list of authority search results, select "Merge" from the Actions menu of two authority records. Test both the initial selection screen and the source/destination merging view. - searchresultlist.tt - The authority search results page. Each of these pages should look correct, with a single centered column with wide margins on either side. At lower browser widths the margins should disappear. Sorry, patch does not apply :( I get: fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/authorities/blinddetail-biblio-search.tt). Using git-bz with automatic dependency resolution this applies without any trouble for me on master. Did you apply the patch for Bug 19786 first? Thanks for testing! Created attachment 72626 [details] [review] Bug 19983: Switch single-column templates to Bootstrap grid: Authorities This patch updates several single-column Authorities module templates to use the Bootstrap grid. - authorities-home - The home page of the Authorities module. - authorities.tt - The authority add/edit page. - blinddetail-biblio-search.tt - Not really testable -- It's the small popup window which appears during the process of linking an authority to a MARC record. - detail.tt - The authority detail page. Search for an authority record and click on the "details" link in the search results. - merge.tt - From a list of authority search results, select "Merge" from the Actions menu of two authority records. Test both the initial selection screen and the source/destination merging view. - searchresultlist.tt - The authority search results page. Each of these pages should look correct, with a single centered column with wide margins on either side. At lower browser widths the margins should disappear. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Created attachment 73245 [details] [review] Bug 19983: Switch single-column templates to Bootstrap grid: Authorities This patch updates several single-column Authorities module templates to use the Bootstrap grid. - authorities-home - The home page of the Authorities module. - authorities.tt - The authority add/edit page. - blinddetail-biblio-search.tt - Not really testable -- It's the small popup window which appears during the process of linking an authority to a MARC record. - detail.tt - The authority detail page. Search for an authority record and click on the "details" link in the search results. - merge.tt - From a list of authority search results, select "Merge" from the Actions menu of two authority records. Test both the initial selection screen and the source/destination merging view. - searchresultlist.tt - The authority search results page. Each of these pages should look correct, with a single centered column with wide margins on either side. At lower browser widths the margins should disappear. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 18.05, thanks to everybody involved! |