Summary: | If no z39.50/SRU servers, the z39.50/SRU buttons should not show | ||
---|---|---|---|
Product: | Koha | Reporter: | Aleisha Amohia <aleisha> |
Component: | System Administration | Assignee: | Grace <gracesmythh> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, jonathan.druart, nick |
Version: | Main | Keywords: | Academy |
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Small patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Bug Depends on: | |||
Bug Blocks: | 20047, 20430 | ||
Attachments: |
Bug 19987: If no z39.50/SRU servers the button should not show
Bug 19987: If no z39.50/SRU servers the button should not show Bug 19987: If no z39.50/SRU servers the button should not show Bug 19987: If no z39.50/SRU servers the button should not show |
Description
Aleisha Amohia
2018-01-16 23:37:46 UTC
Created attachment 70659 [details] [review] Bug 19987: If no z39.50/SRU servers the button should not show Test plan: [1.] Load the patch and make sure you have some Z39.50/SRU servers (Administration => Z39.50/SRU servers administration) [2.] Then go to authorities and notice that the 'New from Z39.50/SRU' button is there [3.] Next go to cataloging and notice that the 'New from Z39.50/SRU' button is there too [4.] Now make sure you have no Z39.50/SRU servers (remove the servers) (Administration => Z39.50/SRU servers administration) [5.] Go to authorities and notice that the 'New from Z39.50/SRU' button is not there [6.] Lastly go to cataloging and notice that the 'New from Z39.50/SRU' button is not there too Does this patch depend on another one? It doesn't apply for me on master. Created attachment 70709 [details] [review] Bug 19987: If no z39.50/SRU servers the button should not show Test plan: [1.] Load the patch and make sure you have some Z39.50/SRU servers (Administration => Z39.50/SRU servers administration) [2.] Then go to authorities and notice that the 'New from Z39.50/SRU' button is there [3.] Next go to cataloging and notice that the 'New from Z39.50/SRU' button is there too [4.] Now make sure you have no Z39.50/SRU servers (remove the servers) (Administration => Z39.50/SRU servers administration) [5.] Go to authorities and notice that the 'New from Z39.50/SRU' button is not there [6.] Lastly go to cataloging and notice that the 'New from Z39.50/SRU' Z39.50/SRU' button is not there too :) Created attachment 70744 [details] [review] Bug 19987: If no z39.50/SRU servers the button should not show Test plan: [1.] Load the patch and make sure you have some Z39.50/SRU servers (Administration => Z39.50/SRU servers administration) [2.] Then go to authorities and notice that the 'New from Z39.50/SRU' button is there [3.] Next go to cataloging and notice that the 'New from Z39.50/SRU' button is there too [4.] Now make sure you have no Z39.50/SRU servers (remove the servers) (Administration => Z39.50/SRU servers administration) [5.] Go to authorities and notice that the 'New from Z39.50/SRU' button is not there [6.] Lastly go to cataloging and notice that the 'New from Z39.50/SRU' button is not there too :) Signed-off-by: Owen Leonard <oleonard@myacpl.org> I added a missing [% END %] during signoff. Hope no one minds! A good follow-up would be to address the pages in Acquisitions which let you add to a basket from Z39.50 ("From an external source"). The link is in acquisitions-add-to-basket.inc which is included in acqui/basket.tt, acqui/booksellers.tt, and acqui/neworderbiblio.tt. Created attachment 70754 [details] [review] Bug 19987: If no z39.50/SRU servers the button should not show Test plan: [1.] Load the patch and make sure you have some Z39.50/SRU servers (Administration => Z39.50/SRU servers administration) [2.] Then go to authorities and notice that the 'New from Z39.50/SRU' button is there [3.] Next go to cataloging and notice that the 'New from Z39.50/SRU' button is there too [4.] Now make sure you have no Z39.50/SRU servers (remove the servers) (Administration => Z39.50/SRU servers administration) [5.] Go to authorities and notice that the 'New from Z39.50/SRU' button is not there [6.] Lastly go to cataloging and notice that the 'New from Z39.50/SRU' button is not there too :) Signed-off-by: Owen Leonard <oleonard@myacpl.org> I added a missing [% END %] during signoff. Hope no one minds! Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Patch pushed to master for 18.05. Congratulations Grace for your first patch in! Awesome work all! Pushed to Stable for 17.11.02 Pushed to 17.05.x for v17.05.09 |