Bug 19989

Summary: opac-memberentry.pl has a FIXME that can be fixed
Product: Koha Reporter: Aleisha Amohia <aleisha>
Component: OPACAssignee: Zoe Bennett <zoebennett1308>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: jonathan.druart, katrin.fischer, nick
Version: unspecifiedKeywords: Academy
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 17091    
Bug Blocks:    
Attachments: Bug 19989: fixing th FIXME so that new requests replace old request
Bug 19989: fixing the FIXME so that new requests replace old request
Bug 19989: Fix the FIXME so that new requests replace old request

Description Aleisha Amohia 2018-01-17 01:57:41 UTC
There is a FIXME that was waiting for Bug 17091 to be pushed; it has now been pushed.

Line 275

To test if the recommended fix works, submit a change to the user's details through the OPAC, then confirm that this request is the only request from the user back in the staff client (members/members-update.pl). New requests replace old requests.
Comment 1 Zoe Bennett 2018-01-17 04:04:05 UTC
Created attachment 70600 [details] [review]
Bug 19989: fixing th FIXME so that new requests replace old request

Test:
1)Make a change to the user in the OPAC
2)In the staff client make sure this is the only request
Comment 2 Owen Leonard 2018-01-17 13:42:59 UTC
Created attachment 70616 [details] [review]
Bug 19989: fixing the FIXME so that new requests replace old request

Test:
1) Make a change to the user in the OPAC
2) In the staff client make sure this is the only request

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Katrin Fischer 2018-02-04 15:26:25 UTC
Created attachment 71201 [details] [review]
Bug 19989: Fix the FIXME so that new requests replace old request

Test:
1) Make a change to the user in the OPAC
2) In the staff client make sure this is the only request

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Jonathan Druart 2018-02-05 12:58:31 UTC
Pushed to master for 18.05, thanks to everybody involved!
Comment 5 Nick Clemens 2018-02-16 00:55:24 UTC
Awesome work all! Enhancement not backported to stable.