Summary: | use Modern::Perl in Authorities perl scripts | ||
---|---|---|---|
Product: | Koha | Reporter: | Aleisha Amohia <aleisha> |
Component: | MARC Authority data support | Assignee: | Jasmine Amohia <jasmineamohia.student> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | fridolin.somers, gracesmythh, J.P.Knight, jasmineamohia.student, jesse, martin.renvoize, nick |
Version: | unspecified | Keywords: | Academy |
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 19994: use Modern::Perl in Authorities perl scripts
Bug 19994: use Modern::Perl in Authorities perl scripts Bug 19994: Used Modern::Perl in Authorities perl scripts Bug 19994: Used Modern::Perl in Authorities perl scripts Bug 19994: Used Modern::Perl in Authorities perl scripts |
Description
Aleisha Amohia
2018-01-17 04:37:13 UTC
Created attachment 70661 [details] [review] Bug 19994: use Modern::Perl in Authorities perl scripts Test Case: Check the following files have been updated from use strict; use warnings; to use Modern::Perl; auth_finder.pl authorities-home.pl authorities-list.pl authorities.pl blinddetail-biblio-search.pl detail-biblio-search.pl detail.pl export.pl merge.pl merge_ajax.pl Created attachment 70675 [details] [review] Bug 19994: use Modern::Perl in Authorities perl scripts Test Case: Check the following files have been updated from use strict; use warnings; to use Modern::Perl; auth_finder.pl authorities-home.pl authorities-list.pl authorities.pl blinddetail-biblio-search.pl detail-biblio-search.pl detail.pl export.pl merge.pl merge_ajax.pl The files: authorities/detail-biblio-search.pl authorities/export.pl still appear to have a use strict in them after applying the patch. Patch needs rebasing: Applying: Bug 19994: use Modern::Perl in Authorities perl scripts Using index info to reconstruct a base tree... M authorities/auth_finder.pl M authorities/authorities-home.pl A authorities/authorities-list.pl M authorities/authorities.pl M authorities/blinddetail-biblio-search.pl M authorities/detail.pl M authorities/merge.pl Falling back to patching base and 3-way merge... Auto-merging authorities/merge.pl Auto-merging authorities/detail.pl Auto-merging authorities/blinddetail-biblio-search.pl Auto-merging authorities/authorities.pl CONFLICT (modify/delete): authorities/authorities-list.pl deleted in HEAD and modified in Bug 19994: use Modern::Perl in Authorities perl scripts. Version Bug 19994: use Modern::Perl in Authorities perl scripts of authorities/authorities-list.pl left in tree. Auto-merging authorities/authorities-home.pl Auto-merging authorities/auth_finder.pl Failed to merge in the changes. Patch failed at 0001 Bug 19994: use Modern::Perl in Authorities perl scripts Created attachment 84109 [details] [review] Bug 19994: Used Modern::Perl in Authorities perl scripts Test plan: 1. Review code of the following files and confirm that 'use Modern::Perl;' is used in place of 'use strict; use warnings;' auth_finder.pl authorities-home.pl authorities.pl blinddetail-biblio-search.pl detail-biblio-search.pl detail.pl export.pl merge.pl merge_ajax.pl Created attachment 84178 [details] [review] Bug 19994: Used Modern::Perl in Authorities perl scripts Test plan: 1. Review code of the following files and confirm that 'use Modern::Perl;' is used in place of 'use strict; use warnings;' auth_finder.pl authorities-home.pl authorities.pl blinddetail-biblio-search.pl detail-biblio-search.pl detail.pl export.pl merge.pl merge_ajax.pl Signed-off-by: David Nind <david@davidnind.com> Created attachment 84255 [details] [review] Bug 19994: Used Modern::Perl in Authorities perl scripts Test plan: 1. Review code of the following files and confirm that 'use Modern::Perl;' is used in place of 'use strict; use warnings;' auth_finder.pl authorities-home.pl authorities.pl blinddetail-biblio-search.pl detail-biblio-search.pl detail.pl export.pl merge.pl merge_ajax.pl Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Awesome work all! Pushed to master for 19.05 Pushed to 18.11.x for 18.11.03 Pushed to 18.05.x for 18.05.09 Trivial, I dont push to 17.11.x |