Bug 19999

Summary: use Modern::Perl in Labels perl scripts
Product: Koha Reporter: Aleisha Amohia <aleisha>
Component: Architecture, internals, and plumbingAssignee: Zoe Bennett <zoebennett1308>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: jonathan.druart, nick
Version: unspecifiedKeywords: Academy
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: Bug 19999: Replacing 'use strict; use warnings;' with 'use Modern::Perl;'

Description Aleisha Amohia 2018-01-17 04:45:34 UTC
use Modern::Perl should be used instead of use strict; use warnings;

Relevant in:
label-create-csv.pl
label-create-pdf.pl
label-create-xml.pl
label-edit-batch.pl
label-edit-layout.pl
label-edit-profile.pl
label-edit-template.pl
label-home.pl
label-item-search.pl
label-print.pl
spinelabel-home.pl
spinelabel-print.pl
Comment 1 Zoe Bennett 2018-01-17 23:06:50 UTC
Created attachment 70649 [details] [review]
Bug 19999: Replacing 'use strict; use warnings;' with 'use Modern::Perl;'

Test Plan:
- Check that it now says 'use Modern::Perl;' and not 'use strict; use
warnings;' in the following labels perl scripts:

label-create-csv.pl
label-create-pdf.pl
label-create-xml.pl
label-edit-batch.pl
label-edit-layout.pl
label-edit-profile.pl
label-edit-template.pl
label-home.pl
label-item-search.pl
label-print.pl
spinelabel-home.pl
spinelabel-print.pl
Comment 2 Jonathan Druart 2018-02-05 12:48:55 UTC
Skipping SO and QA, trivial changes.
Comment 3 Jonathan Druart 2018-02-05 12:59:14 UTC
Pushed to master for 18.05, thanks to everybody involved!
Comment 4 Nick Clemens (kidclamp) 2018-02-16 00:58:30 UTC
Awesome work all! Enhancement not backported to stable.