|
Description
Tomás Cohen Arazi (tcohen)
2018-01-17 13:31:20 UTC
Created attachment 70627 [details] [review] Bug 20004: Unit tests This patch adapts the unit tests for the cities endpoint to the requirements from the RFC. This tests are expected to just fail without the needed followup. To test: - Run: $ kshell k$ prove t/db_dependent/api/v1/cities.t => FAIL: Tests obviously don't pass without the followup patch. Created attachment 70628 [details] [review] Bug 20004: Adapt /v1/cities to new naming guidelines This patch implements the changes required by the cities endpoint RFC [1]. It uses the objects.search helper, and relies on bug 19686. To test: - Apply the patches - Compare the spec with the RFC (api/v1/swagger/definitions/city.json) => SUCCESS: It makes sense - Run: $ kshell k$ prove t/db_dependent/api/v1/cities.t => Tests pass! - Sign off :-D Patch does not apply Applying: Bug 20004: Adapt /v1/cities to new naming guidelines fatal: sha1 information is lacking or useless (api/v1/swagger/parameters.json). Created attachment 71649 [details] [review] Bug 20004: Unit tests This patch adapts the unit tests for the cities endpoint to the requirements from the RFC. This tests are expected to just fail without the needed followup. To test: - Run: $ kshell k$ prove t/db_dependent/api/v1/cities.t => FAIL: Tests obviously don't pass without the followup patch. Created attachment 71651 [details] [review] Bug 20004: Adapt /v1/cities to new naming guidelines This patch implements the changes required by the cities endpoint RFC [1]. It uses the objects.search helper, and relies on bug 19686. To test: - Apply the patches - Compare the spec with the RFC (api/v1/swagger/definitions/city.json) => SUCCESS: It makes sense - Run: $ kshell k$ prove t/db_dependent/api/v1/cities.t => Tests pass! - Sign off :-D Created attachment 71653 [details] [review] Bug 20004: Adapt /v1/cities to new naming guidelines This patch implements the changes required by the cities endpoint RFC [1]. It uses the objects.search helper, and relies on bug 19686. To test: - Apply the patches - Compare the spec with the RFC (api/v1/swagger/definitions/city.json) => SUCCESS: It makes sense - Run: $ kshell k$ prove t/db_dependent/api/v1/cities.t => Tests pass! - Sign off :-D Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Created attachment 71665 [details] [review] Bug 20004: Unit tests This patch adapts the unit tests for the cities endpoint to the requirements from the RFC. This tests are expected to just fail without the needed followup. To test: - Run: $ kshell k$ prove t/db_dependent/api/v1/cities.t => FAIL: Tests obviously don't pass without the followup patch. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Created attachment 71666 [details] [review] Bug 20004: Adapt /v1/cities to new naming guidelines This patch implements the changes required by the cities endpoint RFC [1]. It uses the objects.search helper, and relies on bug 19686. To test: - Apply the patches - Compare the spec with the RFC (api/v1/swagger/definitions/city.json) => SUCCESS: It makes sense - Run: $ kshell k$ prove t/db_dependent/api/v1/cities.t => Tests pass! - Sign off :-D Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Created attachment 71823 [details] [review] Bug 20004: Unit tests This patch adapts the unit tests for the cities endpoint to the requirements from the RFC. This tests are expected to just fail without the needed followup. To test: - Run: $ kshell k$ prove t/db_dependent/api/v1/cities.t => FAIL: Tests obviously don't pass without the followup patch. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 71824 [details] [review] Bug 20004: Unit tests This patch adapts the unit tests for the cities endpoint to the requirements from the RFC. This tests are expected to just fail without the needed followup. To test: - Run: $ kshell k$ prove t/db_dependent/api/v1/cities.t => FAIL: Tests obviously don't pass without the followup patch. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 71825 [details] [review] Bug 20004: Adapt /v1/cities to new naming guidelines This patch implements the changes required by the cities endpoint RFC [1]. It uses the objects.search helper, and relies on bug 19686. To test: - Apply the patches - Compare the spec with the RFC (api/v1/swagger/definitions/city.json) => SUCCESS: It makes sense - Run: $ kshell k$ prove t/db_dependent/api/v1/cities.t => Tests pass! - Sign off :-D Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 71826 [details] [review] Bug 20004: Fix POD Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> (In reply to Kyle M Hall from comment #12) > Created attachment 71826 [details] [review] [review] > Bug 20004: Fix POD Well, you are cheating QA tests here :) Pushed to master for 18.05, thanks to everybody involved! |